From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/2] qcow2: Undo leaked allocations in co_writev
Date: Fri, 11 Oct 2013 09:36:24 +0200 [thread overview]
Message-ID: <1381476986-3032-1-git-send-email-mreitz@redhat.com> (raw)
If a write request on a qcow2 image spans more than one L2 table,
qcow2_alloc_cluster_offset cannot allocate the required clusters in a
single operation. This results in leaks, if a subsequent (atomic)
allocation in that function fails, because qcow2_co_writev does not undo
unused cluster allocations.
This series implements that deallocation and provides a test for it.
v2:
- patch 1: added a comment about the significance of future changes at
a certain point in qcow2_co_writev
- patch 1: changed QCOW2_DISCARD_ALWAYS to QCOW2_DISCARD_OTHER
Max Reitz (2):
qcow2: Undo leaked allocations in co_writev
qemu-iotests: Extend test 026
block/qcow2.c | 15 +++++++++++++++
tests/qemu-iotests/026 | 31 +++++++++++++++++++++++++++++++
tests/qemu-iotests/026.out | 8 ++++++++
tests/qemu-iotests/026.out.nocache | 8 ++++++++
4 files changed, 62 insertions(+)
--
1.8.3.1
next reply other threads:[~2013-10-11 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 7:36 Max Reitz [this message]
2013-10-11 7:36 ` [Qemu-devel] [PATCH v2 1/2] qcow2: Undo leaked allocations in co_writev Max Reitz
2013-10-11 7:36 ` [Qemu-devel] [PATCH v2 2/2] qemu-iotests: Extend test 026 Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381476986-3032-1-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).