From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUbwW-00011V-CK for qemu-devel@nongnu.org; Fri, 11 Oct 2013 08:35:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUbwM-00075n-1p for qemu-devel@nongnu.org; Fri, 11 Oct 2013 08:35:44 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:56404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUbwK-000757-IX for qemu-devel@nongnu.org; Fri, 11 Oct 2013 08:35:33 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 Oct 2013 18:05:26 +0530 From: "Aneesh Kumar K.V" Date: Fri, 11 Oct 2013 18:05:08 +0530 Message-Id: <1381494908-25933-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH] target-ppc: Fix htab_mask calculation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: agraf@suse.de, paulus@samba.org Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, "Aneesh Kumar K.V" From: "Aneesh Kumar K.V" Correctly update the htab_mask using the return value of KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1 on GET_SREGS for HV. So don't update htab_mask if sdr1 is found to be zero. Fix the pte index calculation to be same as that found in the kernel Signed-off-by: Aneesh Kumar K.V --- hw/ppc/spapr.c | 3 ++- target-ppc/mmu-hash64.c | 2 +- target-ppc/mmu_helper.c | 4 +++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 4a23b6a..4ce069b 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -717,7 +717,8 @@ static void spapr_cpu_reset(void *opaque) env->external_htab = (uint8_t *)spapr->htab; env->htab_base = -1; - env->htab_mask = HTAB_SIZE(spapr) - 1; + /* 128 (2**7) bytes in each HPTEG */ + env->htab_mask = (1ULL << ((spapr)->htab_shift - 7)) - 1; env->spr[SPR_SDR1] = (target_ulong)(uintptr_t)spapr->htab | (spapr->htab_shift - 18); } diff --git a/target-ppc/mmu-hash64.c b/target-ppc/mmu-hash64.c index aeb4593..0deeae6 100644 --- a/target-ppc/mmu-hash64.c +++ b/target-ppc/mmu-hash64.c @@ -347,7 +347,7 @@ static hwaddr ppc_hash64_pteg_search(CPUPPCState *env, hwaddr hash, unsigned long pte_index; struct ppc_hash64_hpte_token *token; - pte_index = (hash * HPTES_PER_GROUP) & env->htab_mask; + pte_index = (hash & env->htab_mask) * HPTES_PER_GROUP; token = ppc_hash64_start_access(ppc_env_get_cpu(env), pte_index); if (!token) { return -1; diff --git a/target-ppc/mmu_helper.c b/target-ppc/mmu_helper.c index 04a840b..0322304 100644 --- a/target-ppc/mmu_helper.c +++ b/target-ppc/mmu_helper.c @@ -2025,7 +2025,9 @@ void ppc_store_sdr1(CPUPPCState *env, target_ulong value) " stored in SDR1\n", htabsize); htabsize = 28; } - env->htab_mask = (1ULL << (htabsize + 18)) - 1; + if (htabsize) { + env->htab_mask = (1ULL << (htabsize + 18)) - 1; + } env->htab_base = value & SDR_64_HTABORG; } else #endif /* defined(TARGET_PPC64) */ -- 1.8.1.2