[Qemu-devel] [PATCH 1/7] vmware_vga: port to test_and_clear instead of test/reset

[Juan Quintela <quintela@redhat.com>]

From: Juan Quintela <quintela@trasno.org>

I am assuming that we are testing all the device pages on the loop, that is right?

Signed-off-by: Juan Quintela <quintela@trasno.org>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 hw/display/vmware_vga.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index a6a8cdc..9852a79 100644
--- a/hw/display/vmware_vga.c
+++ b/hw/display/vmware_vga.c
@@ -1082,7 +1082,7 @@ static void vmsvga_update_display(void *opaque)
      */
     if (memory_region_is_logging(&s->vga.vram)) {
         vga_sync_dirty_bitmap(&s->vga);
-        dirty = memory_region_get_dirty(&s->vga.vram, 0,
+        dirty = memory_region_test_and_clear_dirty(&s->vga.vram, 0,
             surface_stride(surface) * surface_height(surface),
             DIRTY_MEMORY_VGA);
     }
@@ -1091,11 +1091,6 @@ static void vmsvga_update_display(void *opaque)
         dpy_gfx_update(s->vga.con, 0, 0,
                    surface_width(surface), surface_height(surface));
     }
-    if (dirty) {
-        memory_region_reset_dirty(&s->vga.vram, 0,
-            surface_stride(surface) * surface_height(surface),
-            DIRTY_MEMORY_VGA);
-    }
 }

 static void vmsvga_reset(DeviceState *dev)
-- 
1.8.3.1