qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 18/61] qemu-iotests: Discard preallocated zero clusters
Date: Fri, 11 Oct 2013 17:05:08 +0200	[thread overview]
Message-ID: <1381503951-27985-19-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1381503951-27985-1-git-send-email-kwolf@redhat.com>

From: Max Reitz <mreitz@redhat.com>

Add a new test case for discarding preallocated zero clusters; doing
this should not result in any leaks.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 tests/qemu-iotests/066     | 63 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/066.out | 13 ++++++++++
 tests/qemu-iotests/group   |  1 +
 3 files changed, 77 insertions(+)
 create mode 100755 tests/qemu-iotests/066
 create mode 100644 tests/qemu-iotests/066.out

diff --git a/tests/qemu-iotests/066 b/tests/qemu-iotests/066
new file mode 100755
index 0000000..1c2452b
--- /dev/null
+++ b/tests/qemu-iotests/066
@@ -0,0 +1,63 @@
+#!/bin/bash
+#
+# Test case for discarding preallocated zero clusters in qcow2
+#
+# Copyright (C) 2013 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+# creator
+owner=mreitz@redhat.com
+
+seq="$(basename $0)"
+echo "QA output created by $seq"
+
+here="$PWD"
+tmp=/tmp/$$
+status=1	# failure is the default!
+
+_cleanup()
+{
+	_cleanup_test_img
+}
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common.rc
+. ./common.filter
+
+# This tests qocw2-specific low-level functionality
+_supported_fmt qcow2
+_supported_proto generic
+_supported_os Linux
+
+IMGOPTS="compat=1.1"
+IMG_SIZE=64M
+
+echo
+echo "=== Testing snapshotting an image with zero clusters ==="
+echo
+_make_test_img $IMG_SIZE
+# Write some normal clusters, zero them (creating preallocated zero clusters)
+# and discard those
+$QEMU_IO -c "write 0 256k" -c "write -z 0 256k" -c "discard 0 256k" "$TEST_IMG" \
+         | _filter_qemu_io
+# Check the image (there shouldn't be any leaks)
+_check_test_img
+
+# success, all done
+echo "*** done"
+rm -f $seq.full
+status=0
diff --git a/tests/qemu-iotests/066.out b/tests/qemu-iotests/066.out
new file mode 100644
index 0000000..9139780
--- /dev/null
+++ b/tests/qemu-iotests/066.out
@@ -0,0 +1,13 @@
+QA output created by 066
+
+=== Testing snapshotting an image with zero clusters ===
+
+Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 
+wrote 262144/262144 bytes at offset 0
+256 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+wrote 262144/262144 bytes at offset 0
+256 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+discard 262144/262144 bytes at offset 0
+256 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+No errors were found on the image.
+*** done
diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
index f1a68b0..9c94d14 100644
--- a/tests/qemu-iotests/group
+++ b/tests/qemu-iotests/group
@@ -70,3 +70,4 @@
 062 rw auto
 063 rw auto
 065 rw auto
+066 rw auto
-- 
1.8.1.4

  parent reply	other threads:[~2013-10-11 15:06 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11 15:04 [Qemu-devel] [PULL 00/61] Block patches Kevin Wolf
2013-10-11 15:04 ` [Qemu-devel] [PULL 01/61] blockjob: rename BlockJobType to BlockJobDriver Kevin Wolf
2013-10-11 15:04 ` [Qemu-devel] [PULL 02/61] qapi: Introduce enum BlockJobType Kevin Wolf
2013-10-11 15:04 ` [Qemu-devel] [PULL 03/61] qapi: make use of new BlockJobType Kevin Wolf
2013-10-11 15:04 ` [Qemu-devel] [PULL 04/61] qapi: Add ImageInfoSpecific type Kevin Wolf
2013-10-11 15:04 ` [Qemu-devel] [PULL 05/61] block: Add bdrv_get_specific_info Kevin Wolf
2013-10-11 15:04 ` [Qemu-devel] [PULL 06/61] block/qapi: Human-readable ImageInfoSpecific dump Kevin Wolf
2013-10-11 15:04 ` [Qemu-devel] [PULL 07/61] qcow2: Add support for ImageInfoSpecific Kevin Wolf
2013-10-11 15:04 ` [Qemu-devel] [PULL 08/61] qemu-iotests: Discard specific info in _img_info Kevin Wolf
2013-10-11 15:04 ` [Qemu-devel] [PULL 09/61] qemu-iotests: Additional info from qemu-img info Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 10/61] qcow2: Alignment of snapshot table entries Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 11/61] qcow2: Use pread for inactive L1 in overlap check Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 12/61] qcow2: Free preallocated zero clusters Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 13/61] qcow2: Always use error path on writing snapshots Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 14/61] qcow2: Free allocated snapshot table on error Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 15/61] qcow2: Assert against snapshot name/ID overflow Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 16/61] block/get_block_status: avoid redundant callouts on raw devices Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 17/61] block: Add BlockDriver.bdrv_check_ext_snapshot Kevin Wolf
2013-10-11 15:05 ` Kevin Wolf [this message]
2013-10-11 15:05 ` [Qemu-devel] [PULL 19/61] ahci: set ahci mode on reset Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 20/61] block: qemu-iotests for vhdx, read sample dynamic image Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 21/61] qcow2: Add missing space in error message Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 22/61] qcow2: Remove wrong metadata overlap check Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 23/61] qcow2: Fix snapshot restoration in snapshot_create Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 24/61] qcow2: Use better type for numerical snapshot ID Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 25/61] block: Improve driver whitelist checks Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 26/61] qcow2: Use negated overflow check mask Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 27/61] qcow2: Make overlap check mask variable Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 28/61] qcow2: Add overlap-check options Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 29/61] qcow2: Array assigning options to OL check bits Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 30/61] qcow2: Add more overlap check bitmask macros Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 31/61] qcow2: Evaluate overlap check options Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 32/61] block/raw_bsd: Employ error parameter Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 33/61] block/raw-win32: " Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 34/61] blkdebug: " Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 35/61] blkverify: " Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 36/61] qemu-iotests: move blank lines of output in case 059 Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 37/61] block/raw-posix: Employ error parameter Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 38/61] tests: build the helper program by default Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 39/61] build: add command check-clean Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 40/61] vmdk: convert error code to use errp Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 41/61] vmdk: refuse enabling zeroed grain with flat images Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 42/61] qapi-types/visit.py: Pass whole expr dict for structs Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 43/61] qapi-types/visit.py: Inheritance " Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 44/61] blockdev: Introduce DriveInfo.enable_auto_del Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 45/61] blockdev: 'blockdev-add' QMP command Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 46/61] blockdev: Separate ID generation from DriveInfo creation Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 47/61] blockdev: Pass QDict to blockdev_init() Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 48/61] blockdev: Move parsing of 'media' option to drive_init Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 49/61] blockdev: Move parsing of 'if' " Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 50/61] blockdev: Moving parsing of geometry options " Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 51/61] blockdev: Move parsing of 'boot' option " Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 52/61] blockdev: Move bus/unit/index processing " Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 53/61] blockdev: Move virtio-blk device creation " Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 54/61] blockdev: Remove IF_* check for read-only blockdev_init Kevin Wolf
2013-10-15 15:53   ` Stefan Weil
2013-10-15 15:59     ` Kevin Wolf
2013-10-15 16:02       ` Stefan Weil
2013-10-11 15:05 ` [Qemu-devel] [PULL 55/61] qemu-iotests: Check autodel behaviour for device_del Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 56/61] blockdev: Remove 'media' parameter from blockdev_init() Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 57/61] blockdev: Don't disable COR automatically with blockdev-add Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 58/61] blockdev: blockdev_init() error conversion Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 59/61] vmdk: Fix vmdk_parse_extents Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 60/61] qemu-io: Let "open" pass options to block driver Kevin Wolf
2013-10-11 15:05 ` [Qemu-devel] [PULL 61/61] qemu-iotests: Add test for inactive L2 overlap Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381503951-27985-19-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).