From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUeIy-00089F-Bl for qemu-devel@nongnu.org; Fri, 11 Oct 2013 11:07:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUeIs-0005nv-CV for qemu-devel@nongnu.org; Fri, 11 Oct 2013 11:07:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUeIs-0005nr-5g for qemu-devel@nongnu.org; Fri, 11 Oct 2013 11:06:58 -0400 From: Kevin Wolf Date: Fri, 11 Oct 2013 17:05:22 +0200 Message-Id: <1381503951-27985-33-git-send-email-kwolf@redhat.com> In-Reply-To: <1381503951-27985-1-git-send-email-kwolf@redhat.com> References: <1381503951-27985-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 32/61] block/raw_bsd: Employ error parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Max Reitz Propagate errors in raw_create rather than directly reporting and afterwards discarding them. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/raw_bsd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index d61906b..0078c1b 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @@ -140,8 +140,7 @@ static int raw_create(const char *filename, QEMUOptionParameter *options, ret = bdrv_create_file(filename, options, &local_err); if (error_is_set(&local_err)) { - qerror_report_err(local_err); - error_free(local_err); + error_propagate(errp, local_err); } return ret; } -- 1.8.1.4