From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVl2N-0006xb-JU for qemu-devel@nongnu.org; Mon, 14 Oct 2013 12:30:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVl2D-0002c2-He for qemu-devel@nongnu.org; Mon, 14 Oct 2013 12:30:31 -0400 Received: from ssl.serverraum.org ([2a01:4f8:a0:1283::1:2]:45084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVl2D-0002bT-7E for qemu-devel@nongnu.org; Mon, 14 Oct 2013 12:30:21 -0400 From: Michael Walle Date: Mon, 14 Oct 2013 18:29:27 +0200 Message-Id: <1381768175-13520-4-git-send-email-michael@walle.cc> In-Reply-To: <1381768175-13520-1-git-send-email-michael@walle.cc> References: <1381768175-13520-1-git-send-email-michael@walle.cc> Subject: [Qemu-devel] [PULL v2 03/11] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Walle , Antony Pavlov From: Antony Pavlov qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and we don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Reported-by: Peter Crosthwaite Acked-by: Peter Crosthwaite Signed-off-by: Antony Pavlov Signed-off-by: Michael Walle --- hw/char/milkymist-uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c index 2e4b5c5..6e4bc20 100644 --- a/hw/char/milkymist-uart.c +++ b/hw/char/milkymist-uart.c @@ -124,7 +124,7 @@ static void uart_write(void *opaque, hwaddr addr, uint64_t value, switch (addr) { case R_RXTX: if (s->chr) { - qemu_chr_fe_write(s->chr, &ch, 1); + qemu_chr_fe_write_all(s->chr, &ch, 1); } s->regs[R_STAT] |= STAT_TX_EVT; break; -- 1.7.10.4