From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete
Date: Tue, 15 Oct 2013 10:23:24 +0800 [thread overview]
Message-ID: <1381803804-4551-1-git-send-email-famz@redhat.com> (raw)
There is errp passed in, so no need for local_err and error_propagate.
Also drop the backing_filename which is set but unused since 34b5d2c.
Signed-off-by: Fam Zheng <famz@redhat.com>
--
v2: fix typo in subject line.
drop backing_filename.
(Thanks Eric)
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/mirror.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 7b95acf..7a73022 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -505,15 +505,10 @@ static void mirror_iostatus_reset(BlockJob *job)
static void mirror_complete(BlockJob *job, Error **errp)
{
MirrorBlockJob *s = container_of(job, MirrorBlockJob, common);
- Error *local_err = NULL;
int ret;
- ret = bdrv_open_backing_file(s->target, NULL, &local_err);
+ ret = bdrv_open_backing_file(s->target, NULL, errp);
if (ret < 0) {
- char backing_filename[PATH_MAX];
- bdrv_get_full_backing_filename(s->target, backing_filename,
- sizeof(backing_filename));
- error_propagate(errp, local_err);
return;
}
if (!s->synced) {
--
1.8.3.1
next reply other threads:[~2013-10-15 2:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 2:23 Fam Zheng [this message]
2013-10-15 3:05 ` [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete Eric Blake
2013-10-15 3:12 ` Fam Zheng
2013-10-16 18:56 ` Max Reitz
2013-10-17 12:49 ` Stefan Hajnoczi
2013-10-17 13:00 ` Kevin Wolf
2013-10-18 8:51 ` Fam Zheng
2013-10-18 17:59 ` Max Reitz
2013-10-19 8:05 ` Kevin Wolf
2013-10-19 20:02 ` Max Reitz
2013-10-19 8:50 ` Paolo Bonzini
2013-10-18 8:52 ` Stefan Hajnoczi
2013-10-17 12:51 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381803804-4551-1-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).