From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVuaB-0001jo-87 for qemu-devel@nongnu.org; Mon, 14 Oct 2013 22:42:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVua5-0003qp-8h for qemu-devel@nongnu.org; Mon, 14 Oct 2013 22:42:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVua4-0003qe-W4 for qemu-devel@nongnu.org; Mon, 14 Oct 2013 22:41:57 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9F2ftEB001139 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 14 Oct 2013 22:41:56 -0400 From: Fam Zheng Date: Tue, 15 Oct 2013 10:41:51 +0800 Message-Id: <1381804911-3664-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH] qemu-iotests: fix 030 for faster machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com If the block job completes too fast, the test can fail. Change the numbers so the qmp events are more stably captured by the script. A sleep is removed for the same reason. Signed-off-by: Fam Zheng --- tests/qemu-iotests/030 | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index ae56f3b..188b182 100755 --- a/tests/qemu-iotests/030 +++ b/tests/qemu-iotests/030 @@ -403,14 +403,13 @@ class TestStreamStop(iotests.QMPTestCase): result = self.vm.qmp('block-stream', device='drive0') self.assert_qmp(result, 'return', {}) - time.sleep(0.1) events = self.vm.get_qmp_events(wait=False) self.assertEqual(events, [], 'unexpected QMP event: %s' % events) self.cancel_and_wait() class TestSetSpeed(iotests.QMPTestCase): - image_len = 80 * 1024 * 1024 # MB + image_len = 512 * 1024 * 1024 # MB def setUp(self): qemu_img('create', backing_img, str(TestSetSpeed.image_len)) @@ -457,23 +456,23 @@ class TestSetSpeed(iotests.QMPTestCase): self.assert_qmp(result, 'return[0]/device', 'drive0') self.assert_qmp(result, 'return[0]/speed', 0) - result = self.vm.qmp('block-job-set-speed', device='drive0', speed=8 * 1024 * 1024) + result = self.vm.qmp('block-job-set-speed', device='drive0', speed=8 * 1024) self.assert_qmp(result, 'return', {}) # Ensure the speed we set was accepted result = self.vm.qmp('query-block-jobs') self.assert_qmp(result, 'return[0]/device', 'drive0') - self.assert_qmp(result, 'return[0]/speed', 8 * 1024 * 1024) + self.assert_qmp(result, 'return[0]/speed', 8 * 1024) self.cancel_and_wait() # Check setting speed in block-stream works - result = self.vm.qmp('block-stream', device='drive0', speed=4 * 1024 * 1024) + result = self.vm.qmp('block-stream', device='drive0', speed=4 * 1024) self.assert_qmp(result, 'return', {}) result = self.vm.qmp('query-block-jobs') self.assert_qmp(result, 'return[0]/device', 'drive0') - self.assert_qmp(result, 'return[0]/speed', 4 * 1024 * 1024) + self.assert_qmp(result, 'return[0]/speed', 4 * 1024) self.cancel_and_wait() -- 1.8.3.1