From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: cornelia.huck@de.ibm.com, qemu-stable@nongnu.org,
afaerber@suse.de, mst@redhat.com
Subject: [Qemu-devel] [PATCH v2 08/12] virtio-net: switch exit callback to VirtioDeviceClass
Date: Tue, 15 Oct 2013 16:52:49 +0200 [thread overview]
Message-ID: <1381848773-689-9-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1381848773-689-1-git-send-email-pbonzini@redhat.com>
This ensures hot-unplug is handled properly by the proxy.
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/net/virtio-net.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 22dbd05..0911096 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1569,16 +1569,15 @@ static int virtio_net_device_init(VirtIODevice *vdev)
return 0;
}
-static int virtio_net_device_exit(DeviceState *qdev)
+static void virtio_net_device_exit(VirtIODevice *vdev)
{
- VirtIONet *n = VIRTIO_NET(qdev);
- VirtIODevice *vdev = VIRTIO_DEVICE(qdev);
+ VirtIONet *n = VIRTIO_NET(vdev);
int i;
/* This will stop vhost backend if appropriate. */
virtio_net_set_status(vdev, 0);
- unregister_savevm(qdev, "virtio-net", n);
+ unregister_savevm(DEVICE(vdev), "virtio-net", n);
if (n->netclient_name) {
g_free(n->netclient_name);
@@ -1609,8 +1608,6 @@ static int virtio_net_device_exit(DeviceState *qdev)
g_free(n->vqs);
qemu_del_nic(n->nic);
virtio_cleanup(vdev);
-
- return 0;
}
static void virtio_net_instance_init(Object *obj)
@@ -1637,10 +1634,10 @@ static void virtio_net_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
- dc->exit = virtio_net_device_exit;
dc->props = virtio_net_properties;
set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
vdc->init = virtio_net_device_init;
+ vdc->exit = virtio_net_device_exit;
vdc->get_config = virtio_net_get_config;
vdc->set_config = virtio_net_set_config;
vdc->get_features = virtio_net_get_features;
--
1.8.3.1
next prev parent reply other threads:[~2013-10-15 14:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 14:52 [Qemu-devel] [PATCH v2 00/12] virtio: cleanup and fix hot-unplug Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 01/12] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug Paolo Bonzini
2013-10-15 15:05 ` Cornelia Huck
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 02/12] virtio-bus: remove vdev field Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 03/12] virtio-ccw: " Paolo Bonzini
2013-10-15 15:19 ` Cornelia Huck
2013-10-15 15:59 ` Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 04/12] virtio-pci: " Paolo Bonzini
2013-10-15 15:40 ` Michael S. Tsirkin
2013-10-15 15:53 ` Paolo Bonzini
2013-10-15 16:06 ` Michael S. Tsirkin
2013-10-15 16:42 ` Paolo Bonzini
2013-10-15 20:11 ` Michael S. Tsirkin
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 05/12] virtio-bus: cleanup plug/unplug interface Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 06/12] virtio-blk: switch exit callback to VirtioDeviceClass Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 07/12] virtio-serial: " Paolo Bonzini
2013-10-15 14:52 ` Paolo Bonzini [this message]
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 09/12] virtio-scsi: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 10/12] virtio-balloon: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 11/12] virtio-rng: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 12/12] virtio-pci: add device_unplugged callback Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381848773-689-9-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).