qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Marc Zyngier <marc.zyngier@arm.com>, qemu-devel@nongnu.org
Cc: Rusty Russell <rusty@rustcorp.com.au>
Subject: [Qemu-devel] [PATCH 3/7] hw/net/virtio-net: use virtio wrappers to access headers.
Date: Thu, 17 Oct 2013 14:23:38 +1030	[thread overview]
Message-ID: <1381982022-19291-4-git-send-email-rusty@rustcorp.com.au> (raw)
In-Reply-To: <1381982022-19291-1-git-send-email-rusty@rustcorp.com.au>

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
---
 hw/net/virtio-net.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 22dbd05..431a4b6 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -23,6 +23,7 @@
 #include "hw/virtio/virtio-bus.h"
 #include "qapi/qmp/qjson.h"
 #include "monitor/monitor.h"
+#include "hw/virtio/virtio-access.h"
 
 #define VIRTIO_NET_VM_VERSION    11
 
@@ -72,8 +73,8 @@ static void virtio_net_get_config(VirtIODevice *vdev, uint8_t *config)
     VirtIONet *n = VIRTIO_NET(vdev);
     struct virtio_net_config netcfg;
 
-    stw_p(&netcfg.status, n->status);
-    stw_p(&netcfg.max_virtqueue_pairs, n->max_queues);
+    virtio_stw_p(&netcfg.status, n->status);
+    virtio_stw_p(&netcfg.max_virtqueue_pairs, n->max_queues);
     memcpy(netcfg.mac, n->mac, ETH_ALEN);
     memcpy(config, &netcfg, n->config_size);
 }
@@ -618,7 +619,7 @@ static int virtio_net_handle_mac(VirtIONet *n, uint8_t cmd,
 
     s = iov_to_buf(iov, iov_cnt, 0, &mac_data.entries,
                    sizeof(mac_data.entries));
-    mac_data.entries = ldl_p(&mac_data.entries);
+    mac_data.entries = virtio_ldl_p(&mac_data.entries);
     if (s != sizeof(mac_data.entries)) {
         goto error;
     }
@@ -645,7 +646,7 @@ static int virtio_net_handle_mac(VirtIONet *n, uint8_t cmd,
 
     s = iov_to_buf(iov, iov_cnt, 0, &mac_data.entries,
                    sizeof(mac_data.entries));
-    mac_data.entries = ldl_p(&mac_data.entries);
+    mac_data.entries = virtio_ldl_p(&mac_data.entries);
     if (s != sizeof(mac_data.entries)) {
         goto error;
     }
@@ -684,7 +685,7 @@ static int virtio_net_handle_vlan_table(VirtIONet *n, uint8_t cmd,
     NetClientState *nc = qemu_get_queue(n->nic);
 
     s = iov_to_buf(iov, iov_cnt, 0, &vid, sizeof(vid));
-    vid = lduw_p(&vid);
+    vid = virtio_lduw_p(&vid);
     if (s != sizeof(vid)) {
         return VIRTIO_NET_ERR;
     }
@@ -721,7 +722,7 @@ static int virtio_net_handle_mq(VirtIONet *n, uint8_t cmd,
         return VIRTIO_NET_ERR;
     }
 
-    queues = lduw_p(&mq.virtqueue_pairs);
+    queues = virtio_lduw_p(&mq.virtqueue_pairs);
 
     if (queues < VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MIN ||
         queues > VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX ||
@@ -1020,7 +1021,7 @@ static ssize_t virtio_net_receive(NetClientState *nc, const uint8_t *buf, size_t
     }
 
     if (mhdr_cnt) {
-        stw_p(&mhdr.num_buffers, i);
+        virtio_stw_p(&mhdr.num_buffers, i);
         iov_from_buf(mhdr_sg, mhdr_cnt,
                      0,
                      &mhdr.num_buffers, sizeof mhdr.num_buffers);
-- 
1.8.1.2

  parent reply	other threads:[~2013-10-17  3:59 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17  3:53 [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes Rusty Russell
2013-10-17  3:53 ` [Qemu-devel] [PATCH 1/7] virtio_get_byteswap: function for endian-ambivalent targets using virtio Rusty Russell
2013-10-17  3:53 ` [Qemu-devel] [PATCH 2/7] virtio: allow byte swapping for vring and config access Rusty Russell
2013-10-17  3:53 ` Rusty Russell [this message]
2013-10-17  3:53 ` [Qemu-devel] [PATCH 4/7] hw/net/virtio-balloon: use virtio wrappers to access page frame numbers Rusty Russell
2013-10-17  3:53 ` [Qemu-devel] [PATCH 5/7] hw/block/virtio-blk: use virtio wrappers to access headers Rusty Russell
2013-10-17  3:53 ` [Qemu-devel] [PATCH 6/7] hw/scsi/virtio-scsi: " Rusty Russell
2013-10-17  3:53 ` [Qemu-devel] [PATCH 7/7] hw/char/virtio-serial-bus: " Rusty Russell
2013-11-12 11:47 ` [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes Thomas Huth
2013-11-19 23:59   ` Rusty Russell
2014-02-14  9:38 ` Greg Kurz
2014-02-14 11:59   ` Andreas Färber
2014-02-18 12:38     ` [Qemu-devel] [PATCH 0/8] virtio endian-ambivalent target fixes (rebased) Greg Kurz
2014-02-18 12:38       ` [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio Greg Kurz
2014-02-18 14:48         ` Alexander Graf
2014-02-18 15:03           ` Michael S. Tsirkin
2014-02-18 15:02             ` Alexander Graf
2014-02-18 15:11               ` Michael S. Tsirkin
2014-02-18 15:07                 ` Alexander Graf
2014-02-18 15:04             ` Michael S. Tsirkin
2014-02-18 15:12             ` Cornelia Huck
2014-02-18 15:45               ` Cornelia Huck
2014-02-18 16:02                 ` Alexander Graf
2014-02-18 16:17                   ` Cornelia Huck
2014-02-18 16:21                     ` Alexander Graf
2014-02-20 23:26                       ` Rusty Russell
2014-02-18 23:02           ` Andreas Färber
2014-02-18 19:25         ` Andreas Färber
2014-02-19 10:06           ` Greg Kurz
2014-02-20 23:19             ` Rusty Russell
2014-02-18 12:38       ` [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access Greg Kurz
2014-02-18 13:08         ` Cornelia Huck
2014-02-18 13:11           ` Greg Kurz
2014-02-18 12:39       ` [Qemu-devel] [PATCH 3/8] hw/net/virtio-net: use virtio wrappers to access headers Greg Kurz
2014-02-18 12:39       ` [Qemu-devel] [PATCH 4/8] hw/net/virtio-balloon: use virtio wrappers to access page frame numbers Greg Kurz
2014-02-18 12:39       ` [Qemu-devel] [PATCH 5/8] hw/block/virtio-blk: use virtio wrappers to access headers Greg Kurz
2014-02-18 12:39       ` [Qemu-devel] [PATCH 6/8] hw/scsi/virtio-scsi: " Greg Kurz
2014-02-18 12:39       ` [Qemu-devel] [PATCH 7/8] hw/char/virtio-serial-bus: " Greg Kurz
2014-02-18 12:39       ` [Qemu-devel] [PATCH 8/8] hw/9pfs/virtio_9p_device: " Greg Kurz
2014-02-18 19:13       ` [Qemu-devel] [PATCH 0/8] virtio endian-ambivalent target fixes (rebased) Andreas Färber
2014-02-14 15:57   ` [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes Thomas Huth
  -- strict thread matches above, loose matches on Subject: below --
2013-08-08  5:15 [Qemu-devel] [PATCH 0/7] Virtio support for endian-curious guests Rusty Russell
2013-08-08  5:15 ` [Qemu-devel] [PATCH 3/7] hw/net/virtio-net: use virtio wrappers to access headers Rusty Russell
2013-08-08 13:32   ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381982022-19291-4-git-send-email-rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=marc.zyngier@arm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).