From: Gerd Hoffmann <kraxel@redhat.com>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix VNC SASL authentication when using a QXL device
Date: Thu, 17 Oct 2013 11:28:19 +0200 [thread overview]
Message-ID: <1382002099.23424.7.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1381938753-28761-1-git-send-email-cfergeau@redhat.com>
On Mi, 2013-10-16 at 17:52 +0200, Christophe Fergeau wrote:
> ui/vnc.c:vnc_display_open() and spice-server/server/reds.c:do_spice_init()
> are both calling sasl_server_init(). If spice_server_set_sasl_appname()
> hasn't been called, spice-server will call it with "spice" as an appname,
> causing cyrus-sasl to try to use a /etc/sasl2/spice.conf config file rather
> than the /etc/sasl2/qemu.conf file that QEMU uses.
>
> When using -spice sasl on the command line, QEMU properly calls
> spice_server_set_sasl_appname() to set the SASL appname as "qemu",
> but when using a QXL device without using SPICE, spice_server_init()
> is called from qemu_spice_add_interface() without setting the appname
> to "qemu", which then causes the VNC code to try to use spice.conf
> instead of qemu.conf.
patch added to spice patch queue.
thanks,
Gerd
prev parent reply other threads:[~2013-10-17 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 15:52 [Qemu-devel] [PATCH] Fix VNC SASL authentication when using a QXL device Christophe Fergeau
2013-10-17 9:28 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382002099.23424.7.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=cfergeau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).