From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VWjsc-0007TJ-Dn
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 05:28:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VWjsV-0006Sp-DI
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 05:28:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22646)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VWjsV-0006Sk-4y
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 05:28:23 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9H9SMMn016364
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 17 Oct 2013 05:28:22 -0400
Message-ID: <1382002099.23424.7.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 17 Oct 2013 11:28:19 +0200
In-Reply-To: <1381938753-28761-1-git-send-email-cfergeau@redhat.com>
References: <1381938753-28761-1-git-send-email-cfergeau@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Fix VNC SASL authentication when using a
 QXL device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org

On Mi, 2013-10-16 at 17:52 +0200, Christophe Fergeau wrote:
> ui/vnc.c:vnc_display_open() and spice-server/server/reds.c:do_spice_init()
> are both calling sasl_server_init(). If spice_server_set_sasl_appname()
> hasn't been called, spice-server will call it with "spice" as an appname,
> causing cyrus-sasl to try to use a /etc/sasl2/spice.conf config file rather
> than the /etc/sasl2/qemu.conf file that QEMU uses.
> 
> When using -spice sasl on the command line, QEMU properly calls
> spice_server_set_sasl_appname() to set the SASL appname as "qemu",
> but when using a QXL device without using SPICE, spice_server_init()
> is called from qemu_spice_add_interface() without setting the appname
> to "qemu", which then causes the VNC code to try to use spice.conf
> instead of qemu.conf.

patch added to spice patch queue.

thanks,
  Gerd