From: armbru@redhat.com
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, borntraeger@de.ibm.com, afaerber@suse.de,
anthony@codemonkey.ws, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 03/10] cpu: Document why cannot_instantiate_with_device_add_yet
Date: Thu, 17 Oct 2013 15:54:54 +0200 [thread overview]
Message-ID: <1382018101-6102-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1382018101-6102-1-git-send-email-armbru@redhat.com>
From: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qom/cpu.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qom/cpu.c b/qom/cpu.c
index 09c15e6..6e0d54e 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -254,7 +254,11 @@ static void cpu_class_init(ObjectClass *klass, void *data)
k->gdb_read_register = cpu_common_gdb_read_register;
k->gdb_write_register = cpu_common_gdb_write_register;
dc->realize = cpu_common_realizefn;
- dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
+ /*
+ * Reason: CPUs still need special care by board code: wiring up
+ * IRQs, adding reset handlers, halting non-first CPUS, ...
+ */
+ dc->cannot_instantiate_with_device_add_yet = true;
}
static const TypeInfo cpu_type_info = {
--
1.8.1.4
next prev parent reply other threads:[~2013-10-17 13:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 13:54 [Qemu-devel] [PATCH 00/10] Clean up and fix no_user armbru
2013-10-17 13:54 ` [Qemu-devel] [PATCH 01/10] qdev: Replace no_user by cannot_instantiate_with_device_add_yet armbru
2013-10-23 10:11 ` Peter Maydell
2013-10-24 8:59 ` Markus Armbruster
2013-10-17 13:54 ` [Qemu-devel] [PATCH 02/10] sysbus: Set cannot_instantiate_with_device_add_yet armbru
2013-10-23 10:13 ` Peter Maydell
2013-10-24 9:01 ` Markus Armbruster
2013-10-17 13:54 ` armbru [this message]
2013-10-23 9:54 ` [Qemu-devel] [PATCH 03/10] cpu: Document why cannot_instantiate_with_device_add_yet Peter Maydell
2013-10-17 13:54 ` [Qemu-devel] [PATCH 04/10] apic: " armbru
2013-10-23 9:54 ` Peter Maydell
2013-10-17 13:54 ` [Qemu-devel] [PATCH 05/10] pci-host: Consistently set cannot_instantiate_with_device_add_yet armbru
2013-10-23 9:51 ` Peter Maydell
2013-10-24 9:16 ` Markus Armbruster
2013-10-17 13:54 ` [Qemu-devel] [PATCH 06/10] ich9: Document why cannot_instantiate_with_device_add_yet armbru
2013-10-23 9:56 ` Peter Maydell
2013-10-17 13:54 ` [Qemu-devel] [PATCH 07/10] piix3 piix4: Clean up use of cannot_instantiate_with_device_add_yet armbru
2013-10-17 13:54 ` [Qemu-devel] [PATCH 08/10] vt82c686: " armbru
2013-10-23 9:59 ` Peter Maydell
2013-10-17 13:55 ` [Qemu-devel] [PATCH 09/10] isa: " armbru
2013-10-23 10:05 ` Peter Maydell
2013-10-24 9:02 ` Markus Armbruster
2013-10-17 13:55 ` [Qemu-devel] [PATCH 10/10] qdev: Do not let the user try to device_add when it cannot work armbru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382018101-6102-4-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=borntraeger@de.ibm.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).