From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWpcB-00007m-QB for qemu-devel@nongnu.org; Thu, 17 Oct 2013 11:36:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWpc6-0004fp-5M for qemu-devel@nongnu.org; Thu, 17 Oct 2013 11:35:55 -0400 Received: from mail-ea0-x22f.google.com ([2a00:1450:4013:c01::22f]:41596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWpc5-0004fX-7a for qemu-devel@nongnu.org; Thu, 17 Oct 2013 11:35:49 -0400 Received: by mail-ea0-f175.google.com with SMTP id m14so1150352eaj.20 for ; Thu, 17 Oct 2013 08:35:48 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 17 Oct 2013 17:35:33 +0200 Message-Id: <1382024133-15764-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1382024133-15764-1-git-send-email-pbonzini@redhat.com> References: <1382024133-15764-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 5/5] ui/Makefile.objs: delete unnecessary cocoa.o dependency List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Fam Zheng From: Peter Maydell Delete an unnecessary dependency for cocoa.o; we already have a general rule that tells Make that we can build a .o file from a .m source using an ObjC compiler, so this specific rule is unnecessary. Further, it is using the dubious construct "$(SRC_PATH)/$(obj)" to get at the source directory, which will break when $(obj) is redefined as part of the preparation for per-object library support. Signed-off-by: Peter Maydell Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- ui/Makefile.objs | 2 -- 1 file changed, 2 deletions(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index 6ddc0de..f33be47 100644 --- a/ui/Makefile.objs +++ b/ui/Makefile.objs @@ -17,6 +17,4 @@ common-obj-$(CONFIG_GTK) += gtk.o x_keymap.o $(obj)/sdl.o $(obj)/sdl_zoom.o: QEMU_CFLAGS += $(SDL_CFLAGS) -$(obj)/cocoa.o: $(SRC_PATH)/$(obj)/cocoa.m - $(obj)/gtk.o: QEMU_CFLAGS += $(GTK_CFLAGS) $(VTE_CFLAGS) -- 1.8.3.1