qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Roy Franz <roy.franz@linaro.org>
To: qemu-devel@nongnu.org, kwolf@redhat.com, stefanha@redhat.com
Cc: Roy Franz <roy.franz@linaro.org>,
	peter.maydell@linaro.org, patches@linaro.org
Subject: [Qemu-devel] [PATCH 0/2 v3] block, arm: Fix buffered flash writes on VExpress
Date: Sat, 19 Oct 2013 10:04:32 -0700	[thread overview]
Message-ID: <1382202274-8190-1-git-send-email-roy.franz@linaro.org> (raw)
In-Reply-To: <CAFEAcA-3ws1nrdftTBEZnUhWdLnQTx+6y3dQ9wDgm77Lrit8Aw@mail.gmail.com>

Here is my updated patch to fix buffered flash writes on the VExpress
platform.  Buffered writes should now work properly on platforms whose
flash interface width is different from the device width.  The default
is for the device-width to be set to the interface width, so platforms
that can benefit from this change will need to be updated.  This patchset
updates the configuration for the VExpress platform which requires it.
UEFI firmware uses buffered writes for persistent variable storage,
and this patchset enables this usage on QEMU.

Changes from v2:
(All changes in patch 2/2, 1/1 unchanged.)
* Set flash invariant properties directly in VExpress specific flash init
  routine rather than passing long argument list.
* Fix typo in comment.

Changes from v1:
* Add device-width property and use this to mask write length instead
  of devices mas write length
* Update vexpress init code to set device-width to proper value.

Roy Franz (2):
  Add device-width property to pflash_cfi01
  Set proper device-width for vexpress flash

 hw/arm/vexpress.c       |   43 +++++++++++++++++++++++++++++++++----------
 hw/block/pflash_cfi01.c |   21 +++++++++++++--------
 2 files changed, 46 insertions(+), 18 deletions(-)

-- 
1.7.10.4

  reply	other threads:[~2013-10-19 17:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-18 18:50 [Qemu-devel] [PATCH 0/2 v2] block, arm: Fix buffered flash writes on VExpress Roy Franz
2013-10-18 18:50 ` [Qemu-devel] [PATCH 1/2 v2] Add device-width property to pflash_cfi01 Roy Franz
2013-10-18 18:50 ` [Qemu-devel] [PATCH 2/2 v2] Set proper device-width for vexpress flash Roy Franz
2013-10-19  9:47   ` Peter Maydell
2013-10-19 17:04     ` Roy Franz [this message]
2013-10-19 17:04       ` [Qemu-devel] [PATCH 1/2 v3] block: Add device-width property to pflash_cfi01 Roy Franz
2013-10-19 20:59         ` Peter Maydell
2013-10-19 17:04       ` [Qemu-devel] [PATCH 2/2 v3] block, arm: Set proper device-width for vexpress flash Roy Franz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382202274-8190-1-git-send-email-roy.franz@linaro.org \
    --to=roy.franz@linaro.org \
    --cc=kwolf@redhat.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).