qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, lcapitulino@redhat.com,
	stefanha@redhat.com, pbonzini@redhat.com,
	Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 5/6] qapi: remove var monitor_event_names[]
Date: Mon, 21 Oct 2013 10:16:04 +0800	[thread overview]
Message-ID: <1382321765-29052-6-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)
In-Reply-To: <1382321765-29052-1-git-send-email-xiawenc@linux.vnet.ibm.com>

Use the generated table in qapi-types.h.

Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
 monitor.c |   36 ++----------------------------------
 1 files changed, 2 insertions(+), 34 deletions(-)

diff --git a/monitor.c b/monitor.c
index b2c64de..7b8bd5e 100644
--- a/monitor.c
+++ b/monitor.c
@@ -478,38 +478,6 @@ static void timestamp_put(QDict *qdict)
 }
 
 
-static const char *monitor_event_names[] = {
-    [Q_EVENT_SHUTDOWN] = "SHUTDOWN",
-    [Q_EVENT_RESET] = "RESET",
-    [Q_EVENT_POWERDOWN] = "POWERDOWN",
-    [Q_EVENT_STOP] = "STOP",
-    [Q_EVENT_RESUME] = "RESUME",
-    [Q_EVENT_VNC_CONNECTED] = "VNC_CONNECTED",
-    [Q_EVENT_VNC_INITIALIZED] = "VNC_INITIALIZED",
-    [Q_EVENT_VNC_DISCONNECTED] = "VNC_DISCONNECTED",
-    [Q_EVENT_BLOCK_IO_ERROR] = "BLOCK_IO_ERROR",
-    [Q_EVENT_RTC_CHANGE] = "RTC_CHANGE",
-    [Q_EVENT_WATCHDOG] = "WATCHDOG",
-    [Q_EVENT_SPICE_CONNECTED] = "SPICE_CONNECTED",
-    [Q_EVENT_SPICE_INITIALIZED] = "SPICE_INITIALIZED",
-    [Q_EVENT_SPICE_DISCONNECTED] = "SPICE_DISCONNECTED",
-    [Q_EVENT_BLOCK_JOB_COMPLETED] = "BLOCK_JOB_COMPLETED",
-    [Q_EVENT_BLOCK_JOB_CANCELLED] = "BLOCK_JOB_CANCELLED",
-    [Q_EVENT_BLOCK_JOB_ERROR] = "BLOCK_JOB_ERROR",
-    [Q_EVENT_BLOCK_JOB_READY] = "BLOCK_JOB_READY",
-    [Q_EVENT_DEVICE_DELETED] = "DEVICE_DELETED",
-    [Q_EVENT_DEVICE_TRAY_MOVED] = "DEVICE_TRAY_MOVED",
-    [Q_EVENT_NIC_RX_FILTER_CHANGED] = "NIC_RX_FILTER_CHANGED",
-    [Q_EVENT_SUSPEND] = "SUSPEND",
-    [Q_EVENT_SUSPEND_DISK] = "SUSPEND_DISK",
-    [Q_EVENT_WAKEUP] = "WAKEUP",
-    [Q_EVENT_BALLOON_CHANGE] = "BALLOON_CHANGE",
-    [Q_EVENT_SPICE_MIGRATE_COMPLETED] = "SPICE_MIGRATE_COMPLETED",
-    [Q_EVENT_GUEST_PANICKED] = "GUEST_PANICKED",
-    [Q_EVENT_BLOCK_IMAGE_CORRUPTED] = "BLOCK_IMAGE_CORRUPTED",
-};
-QEMU_BUILD_BUG_ON(ARRAY_SIZE(monitor_event_names) != Q_EVENT_MAX)
-
 MonitorEventState monitor_event_state[Q_EVENT_MAX];
 QemuMutex monitor_event_state_lock;
 
@@ -657,7 +625,7 @@ void monitor_protocol_event(QEvent event, QObject *data)
 
     assert(event < Q_EVENT_MAX);
 
-    event_name = monitor_event_names[event];
+    event_name = QEvent_lookup[event];
     assert(event_name != NULL);
 
     qmp = qdict_new();
@@ -1070,7 +1038,7 @@ EventInfoList *qmp_query_events(Error **errp)
     QEvent e;
 
     for (e = 0 ; e < Q_EVENT_MAX ; e++) {
-        const char *event_name = monitor_event_names[e];
+        const char *event_name = QEvent_lookup[e];
         assert(event_name != NULL);
         info = g_malloc0(sizeof(*info));
         info->value = g_malloc0(sizeof(*info->value));
-- 
1.7.1

  parent reply	other threads:[~2013-10-21 10:16 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21  2:15 [Qemu-devel] [PATCH 0/6] qapi: generate event defines automatically Wenchao Xia
2013-10-21  2:16 ` [Qemu-devel] [PATCH 1/6] block: use type MonitorEvent directly Wenchao Xia
2013-10-21  2:16 ` [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent Wenchao Xia
2013-10-21 20:38   ` Eric Blake
2013-11-01 14:02   ` Luiz Capitulino
2013-11-01 14:21     ` [Qemu-devel] [libvirt] QEMU 1.6 and drive discard parameter Gareth Bult
2013-11-04  1:59     ` [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent Wenchao Xia
2013-11-04 13:33       ` Luiz Capitulino
2013-11-05  2:17         ` Wenchao Xia
2013-11-05  2:51           ` Luiz Capitulino
2013-11-05  5:31             ` Wenchao Xia
2013-11-05 14:06               ` Luiz Capitulino
2013-11-06  3:25                 ` Wenchao Xia
2013-10-21  2:16 ` [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT Wenchao Xia
2013-10-21 20:41   ` Eric Blake
2013-10-22  2:43     ` Wenchao Xia
2013-10-28 10:44     ` Paolo Bonzini
2013-10-29  5:22       ` Wenchao Xia
2013-10-29 16:09         ` Eric Blake
2013-10-30  7:26           ` Wenchao Xia
2013-11-01 14:06           ` Luiz Capitulino
2013-10-29 18:18     ` Kevin Wolf
2013-10-30  7:27       ` Wenchao Xia
2013-10-30 11:55         ` Paolo Bonzini
2013-10-31  5:26           ` Wenchao Xia
2013-10-21  2:16 ` [Qemu-devel] [PATCH 4/6] qapi: move event defines to qapi-schema.json Wenchao Xia
2013-10-21 20:45   ` Eric Blake
2013-10-21  2:16 ` Wenchao Xia [this message]
2013-10-21 20:47   ` [Qemu-devel] [PATCH 5/6] qapi: remove var monitor_event_names[] Eric Blake
2013-10-21  2:16 ` [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent Wenchao Xia
2013-10-21 21:00   ` Eric Blake
2013-10-22  3:19     ` Wenchao Xia
2013-10-22  3:46       ` Eric Blake
2013-10-23  0:37         ` Wenchao Xia
2013-10-29 23:02           ` Eric Blake
2013-10-30  7:51             ` Wenchao Xia
2013-10-22  6:55     ` Wenchao Xia
2013-10-22  7:33       ` Wenchao Xia
2013-10-22  8:58       ` Eric Blake
2013-10-25  9:16 ` [Qemu-devel] [PATCH 0/6] qapi: generate event defines automatically Wenchao Xia
2013-11-01 14:28 ` Luiz Capitulino
2013-11-04  1:54   ` Wenchao Xia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382321765-29052-6-git-send-email-xiawenc@linux.vnet.ibm.com \
    --to=xiawenc@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).