[Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Stefan Hajnoczi]

There are a number of contributors who maintain block drivers (image
formats and protocols).  They should be listed in the MAINTAINERS file
so that get_maintainer.pl lists them.

Note that commits are still merged through Kevin or Stefan's block tree
but the block driver sub-maintainers are usually the ones to review
patches.

Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 MAINTAINERS | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 77edacf..da18a23 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -857,3 +857,41 @@ Stable 0.10
 L: qemu-stable@nongnu.org
 T: git git://git.qemu-project.org/qemu-stable-0.10.git
 S: Orphan
+
+Block drivers
+-------------
+VMDK
+M: Fam Zheng <famz@redhat.com>
+S: Supported
+F: block/vmdk.c
+
+RBD
+M: Josh Durgin <josh.durgin@dreamhost.com>
+S: Supported
+F: block/rbd.c
+
+Sheepdog
+M: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
+S: Supported
+F: block/sheepdog.c
+
+VHDX
+M: Jeff Cody <jcody@redhat.com>
+S: Supported
+F: block/vhdx.c
+
+VDI
+M: Stefan Weil <sw@weilnetz.de>
+S: Maintained
+F: block/vdi.c
+
+iSCSI
+M: Ronnie Sahlberg <ronniesahlberg@gmail.com>
+M: Paolo Bonzini <pbonzini@redhat.com>
+S: Supported
+F: block/iscsi.c
+
+SSH
+M: Richard W.M. Jones <rjones@redhat.com>
+S: Supported
+F: block/ssh.c
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Richard W.M. Jones]

On Mon, Oct 21, 2013 at 02:26:15PM +0100, Stefan Hajnoczi wrote:
> There are a number of contributors who maintain block drivers (image
> formats and protocols).  They should be listed in the MAINTAINERS file
> so that get_maintainer.pl lists them.
> 
> Note that commits are still merged through Kevin or Stefan's block tree
> but the block driver sub-maintainers are usually the ones to review
> patches.
> 
> Acked-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  MAINTAINERS | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 77edacf..da18a23 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -857,3 +857,41 @@ Stable 0.10
>  L: qemu-stable@nongnu.org
>  T: git git://git.qemu-project.org/qemu-stable-0.10.git
>  S: Orphan
> +
> +Block drivers
> +-------------
> +VMDK
> +M: Fam Zheng <famz@redhat.com>
> +S: Supported
> +F: block/vmdk.c
> +
> +RBD
> +M: Josh Durgin <josh.durgin@dreamhost.com>
> +S: Supported
> +F: block/rbd.c
> +
> +Sheepdog
> +M: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> +S: Supported
> +F: block/sheepdog.c
> +
> +VHDX
> +M: Jeff Cody <jcody@redhat.com>
> +S: Supported
> +F: block/vhdx.c
> +
> +VDI
> +M: Stefan Weil <sw@weilnetz.de>
> +S: Maintained
> +F: block/vdi.c
> +
> +iSCSI
> +M: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> +M: Paolo Bonzini <pbonzini@redhat.com>
> +S: Supported
> +F: block/iscsi.c
> +
> +SSH
> +M: Richard W.M. Jones <rjones@redhat.com>
> +S: Supported
> +F: block/ssh.c
> -- 
> 1.8.3.1

ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Stefan Weil]

Am 21.10.2013 15:26, schrieb Stefan Hajnoczi:
> There are a number of contributors who maintain block drivers (image
> formats and protocols).  They should be listed in the MAINTAINERS file
> so that get_maintainer.pl lists them.
>
> Note that commits are still merged through Kevin or Stefan's block tree
> but the block driver sub-maintainers are usually the ones to review
> patches.
>
> Acked-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  MAINTAINERS | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 77edacf..da18a23 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -857,3 +857,41 @@ Stable 0.10
>  L: qemu-stable@nongnu.org
>  T: git git://git.qemu-project.org/qemu-stable-0.10.git
>  S: Orphan
> +
> +Block drivers
> +-------------
[...]
> +VDI
> +M: Stefan Weil <sw@weilnetz.de>
> +S: Maintained
> +F: block/vdi.c
> +

Acked-by: Stefan Weil <sw@weilnetz.de>

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Josh Durgin]

On 10/21/2013 06:26 AM, Stefan Hajnoczi wrote:
> There are a number of contributors who maintain block drivers (image
> formats and protocols).  They should be listed in the MAINTAINERS file
> so that get_maintainer.pl lists them.
>
> Note that commits are still merged through Kevin or Stefan's block tree
> but the block driver sub-maintainers are usually the ones to review
> patches.
>
> Acked-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   MAINTAINERS | 38 ++++++++++++++++++++++++++++++++++++++
>   1 file changed, 38 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 77edacf..da18a23 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -857,3 +857,41 @@ Stable 0.10
>   L: qemu-stable@nongnu.org
>   T: git git://git.qemu-project.org/qemu-stable-0.10.git
>   S: Orphan
> +
> +Block drivers
> +-------------
> +VMDK
> +M: Fam Zheng <famz@redhat.com>
> +S: Supported
> +F: block/vmdk.c
> +
> +RBD
> +M: Josh Durgin <josh.durgin@dreamhost.com>
> +S: Supported
> +F: block/rbd.c

This still reaches me, but my preferred address is
josh.durgin@inktank.com these days. ACK with that changed.

Josh

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Anthony Liguori]

On Mon, Oct 21, 2013 at 2:26 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> There are a number of contributors who maintain block drivers (image
> formats and protocols).  They should be listed in the MAINTAINERS file
> so that get_maintainer.pl lists them.
>
> Note that commits are still merged through Kevin or Stefan's block tree
> but the block driver sub-maintainers are usually the ones to review
> patches.
>
> Acked-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Acked-by: Anthony Liguori <aliguori@amazon.com>

Although you certainly don't need it.  I assume everything is still
going to flow through the block tree or are you guys looking for these
folks to submit their own pull requests to me?

Regards,

Anthony Liguori

> ---
>  MAINTAINERS | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 77edacf..da18a23 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -857,3 +857,41 @@ Stable 0.10
>  L: qemu-stable@nongnu.org
>  T: git git://git.qemu-project.org/qemu-stable-0.10.git
>  S: Orphan
> +
> +Block drivers
> +-------------
> +VMDK
> +M: Fam Zheng <famz@redhat.com>
> +S: Supported
> +F: block/vmdk.c
> +
> +RBD
> +M: Josh Durgin <josh.durgin@dreamhost.com>
> +S: Supported
> +F: block/rbd.c
> +
> +Sheepdog
> +M: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> +S: Supported
> +F: block/sheepdog.c
> +
> +VHDX
> +M: Jeff Cody <jcody@redhat.com>
> +S: Supported
> +F: block/vhdx.c
> +
> +VDI
> +M: Stefan Weil <sw@weilnetz.de>
> +S: Maintained
> +F: block/vdi.c
> +
> +iSCSI
> +M: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> +M: Paolo Bonzini <pbonzini@redhat.com>
> +S: Supported
> +F: block/iscsi.c
> +
> +SSH
> +M: Richard W.M. Jones <rjones@redhat.com>
> +S: Supported
> +F: block/ssh.c
> --
> 1.8.3.1
>
>

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Richard W.M. Jones]

On Mon, Oct 21, 2013 at 09:19:42PM +0100, Anthony Liguori wrote:
> On Mon, Oct 21, 2013 at 2:26 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > There are a number of contributors who maintain block drivers (image
> > formats and protocols).  They should be listed in the MAINTAINERS file
> > so that get_maintainer.pl lists them.
> >
> > Note that commits are still merged through Kevin or Stefan's block tree
> > but the block driver sub-maintainers are usually the ones to review
> > patches.
> >
> > Acked-by: Kevin Wolf <kwolf@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> Acked-by: Anthony Liguori <aliguori@amazon.com>
> 
> Although you certainly don't need it.  I assume everything is still
> going to flow through the block tree or are you guys looking for these
> folks to submit their own pull requests to me?

Speaking for myself, I would prefer that changes to block/ssh.c go
through the ordinary qemu-devel mailing list or Stefan's tree, and NOT
depend on me.  However devs can CC me on patches to see if I can help
to ACK them.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Kevin Wolf]

Am 21.10.2013 um 22:19 hat Anthony Liguori geschrieben:
> On Mon, Oct 21, 2013 at 2:26 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > There are a number of contributors who maintain block drivers (image
> > formats and protocols).  They should be listed in the MAINTAINERS file
> > so that get_maintainer.pl lists them.
> >
> > Note that commits are still merged through Kevin or Stefan's block tree
> > but the block driver sub-maintainers are usually the ones to review
> > patches.
> >
> > Acked-by: Kevin Wolf <kwolf@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> Acked-by: Anthony Liguori <aliguori@amazon.com>
> 
> Although you certainly don't need it.  I assume everything is still
> going to flow through the block tree or are you guys looking for these
> folks to submit their own pull requests to me?

No, at this point it's just about getting the right people CCed if you
use get_maintainer.pl. Stefan and I will still apply the patches to our
trees (though in many of these areas I would usually ask for the ACK of
the maintainer instead of reviewing myself if he isn't the patch author).

Kevin

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[MORITA Kazutaka]

At Mon, 21 Oct 2013 14:26:15 +0100,
Stefan Hajnoczi wrote:
> 
> There are a number of contributors who maintain block drivers (image
> formats and protocols).  They should be listed in the MAINTAINERS file
> so that get_maintainer.pl lists them.
> 
> Note that commits are still merged through Kevin or Stefan's block tree
> but the block driver sub-maintainers are usually the ones to review
> patches.
> 
> Acked-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  MAINTAINERS | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 77edacf..da18a23 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -857,3 +857,41 @@ Stable 0.10
>  L: qemu-stable@nongnu.org
>  T: git git://git.qemu-project.org/qemu-stable-0.10.git
>  S: Orphan
> +
> +Block drivers
> +-------------
> +VMDK
> +M: Fam Zheng <famz@redhat.com>
> +S: Supported
> +F: block/vmdk.c
> +
> +RBD
> +M: Josh Durgin <josh.durgin@dreamhost.com>
> +S: Supported
> +F: block/rbd.c
> +
> +Sheepdog
> +M: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> +S: Supported
> +F: block/sheepdog.c

Acked-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Paolo Bonzini]

Il 21/10/2013 14:26, Stefan Hajnoczi ha scritto:
> +iSCSI
> +M: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> +M: Paolo Bonzini <pbonzini@redhat.com>
> +S: Supported
> +F: block/iscsi.c

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[MORITA Kazutaka]

At Wed, 23 Oct 2013 15:19:47 +0900,
MORITA Kazutaka wrote:
> 
> > +
> > +Sheepdog
> > +M: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> > +S: Supported
> > +F: block/sheepdog.c
> 
> Acked-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>

Is it okay to add Liu Yuan <tailai.ly@taobao.com> to the sheepdog
maintainer too?  He is a co-maintainer of the sheepdog project with me
and very familiar with sheepdog internals.

Thanks,

Kazutaka

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Liu Yuan]

On Wed, Oct 23, 2013 at 03:51:37PM +0900, MORITA Kazutaka wrote:
> At Wed, 23 Oct 2013 15:19:47 +0900,
> MORITA Kazutaka wrote:
> > 
> > > +
> > > +Sheepdog
> > > +M: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> > > +S: Supported
> > > +F: block/sheepdog.c
> > 
> > Acked-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> 
> Is it okay to add Liu Yuan <tailai.ly@taobao.com> to the sheepdog
> maintainer too?  He is a co-maintainer of the sheepdog project with me
> and very familiar with sheepdog internals.

I'd like to appear to be 'Liu Yuan <namei.unix@gmail.com>' which is a long-term
reachable mail address, if allowed to be on the list.

Thanks
Yuan

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Jeff Cody]

On Mon, Oct 21, 2013 at 02:26:15PM +0100, Stefan Hajnoczi wrote:
> There are a number of contributors who maintain block drivers (image
> formats and protocols).  They should be listed in the MAINTAINERS file
> so that get_maintainer.pl lists them.
> 
> Note that commits are still merged through Kevin or Stefan's block tree
> but the block driver sub-maintainers are usually the ones to review
> patches.
> 
> Acked-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  MAINTAINERS | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 77edacf..da18a23 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -857,3 +857,41 @@ Stable 0.10
>  L: qemu-stable@nongnu.org
>  T: git git://git.qemu-project.org/qemu-stable-0.10.git
>  S: Orphan
> +
> +Block drivers
> +-------------
> +VMDK
> +M: Fam Zheng <famz@redhat.com>
> +S: Supported
> +F: block/vmdk.c
> +
> +RBD
> +M: Josh Durgin <josh.durgin@dreamhost.com>
> +S: Supported
> +F: block/rbd.c
> +
> +Sheepdog
> +M: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> +S: Supported
> +F: block/sheepdog.c
> +
> +VHDX
> +M: Jeff Cody <jcody@redhat.com>
> +S: Supported
> +F: block/vhdx.c

This should probably be block/vhdx* instead

With that,
Acked-by: Jeff Cody <jcody@redhat.com>

> +
> +VDI
> +M: Stefan Weil <sw@weilnetz.de>
> +S: Maintained
> +F: block/vdi.c
> +
> +iSCSI
> +M: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> +M: Paolo Bonzini <pbonzini@redhat.com>
> +S: Supported
> +F: block/iscsi.c
> +
> +SSH
> +M: Richard W.M. Jones <rjones@redhat.com>
> +S: Supported
> +F: block/ssh.c
> -- 
> 1.8.3.1
> 

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

[Peter Lieven]

On 23.10.2013 08:23, Paolo Bonzini wrote:
> Il 21/10/2013 14:26, Stefan Hajnoczi ha scritto:
>> +iSCSI
>> +M: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>> +M: Paolo Bonzini <pbonzini@redhat.com>
>> +S: Supported
>> +F: block/iscsi.c
As I have worked a lot on the iSCSI driver recently I would like
to receive patches as well if possible.

Peter