From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aliguori@us.ibm.com, jcody@redhat.com,
Peter Lieven <pl@kamp.de>,
stefanha@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH] block/vpc: check that the image has not been truncated
Date: Tue, 22 Oct 2013 08:43:25 +0200 [thread overview]
Message-ID: <1382424205-19742-1-git-send-email-pl@kamp.de> (raw)
this adds a check that a dynamic VHD file has not been
accidently truncated (e.g. during transfer or upload).
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block/vpc.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/block/vpc.c b/block/vpc.c
index 1acc1d4..921364e 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -269,6 +269,13 @@ static int vpc_open(BlockDriverState *bs, QDict *options, int flags,
}
}
+ if (s->free_data_block_offset > bdrv_getlength(bs->file)) {
+ ret = -EINVAL;
+ fprintf(stderr, "block-vpc: free_data_block_offset points after"
+ "the end of file. the image has been truncated.\n");
+ goto fail;
+ }
+
s->last_bitmap_offset = (int64_t) -1;
#ifdef CACHE
--
1.7.9.5
next reply other threads:[~2013-10-22 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 6:43 Peter Lieven [this message]
2013-10-22 6:59 ` [Qemu-devel] [PATCH] block/vpc: check that the image has not been truncated Eric Blake
2013-10-22 7:26 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382424205-19742-1-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=aliguori@us.ibm.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).