qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	"qemu-ppc@nongnu.org list:PowerPC" <qemu-ppc@nongnu.org>,
	Anthony Liguori <aliguori@amazon.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL 13/29] xics: add pre_save/post_load dispatchers
Date: Fri, 25 Oct 2013 23:27:38 +0200	[thread overview]
Message-ID: <1382736474-32128-14-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1382736474-32128-1-git-send-email-agraf@suse.de>

From: Alexey Kardashevskiy <aik@ozlabs.ru>

The upcoming support of in-kernel XICS will redefine migration callbacks
for both ICS and ICP so classes and callback pointers are added.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/intc/xics.c        | 56 ++++++++++++++++++++++++++++++++++++++++++++++++---
 include/hw/ppc/xics.h | 26 ++++++++++++++++++++++++
 2 files changed, 79 insertions(+), 3 deletions(-)

diff --git a/hw/intc/xics.c b/hw/intc/xics.c
index 666888d..eeb64f5 100644
--- a/hw/intc/xics.c
+++ b/hw/intc/xics.c
@@ -190,11 +190,35 @@ static void icp_irq(XICSState *icp, int server, int nr, uint8_t priority)
     }
 }
 
+static void icp_dispatch_pre_save(void *opaque)
+{
+    ICPState *ss = opaque;
+    ICPStateClass *info = ICP_GET_CLASS(ss);
+
+    if (info->pre_save) {
+        info->pre_save(ss);
+    }
+}
+
+static int icp_dispatch_post_load(void *opaque, int version_id)
+{
+    ICPState *ss = opaque;
+    ICPStateClass *info = ICP_GET_CLASS(ss);
+
+    if (info->post_load) {
+        return info->post_load(ss, version_id);
+    }
+
+    return 0;
+}
+
 static const VMStateDescription vmstate_icp_server = {
     .name = "icp/server",
     .version_id = 1,
     .minimum_version_id = 1,
     .minimum_version_id_old = 1,
+    .pre_save = icp_dispatch_pre_save,
+    .post_load = icp_dispatch_post_load,
     .fields      = (VMStateField []) {
         /* Sanity check */
         VMSTATE_UINT32(xirr, ICPState),
@@ -229,6 +253,7 @@ static TypeInfo icp_info = {
     .parent = TYPE_DEVICE,
     .instance_size = sizeof(ICPState),
     .class_init = icp_class_init,
+    .class_size = sizeof(ICPStateClass),
 };
 
 /*
@@ -390,10 +415,9 @@ static void ics_reset(DeviceState *dev)
     }
 }
 
-static int ics_post_load(void *opaque, int version_id)
+static int ics_post_load(ICSState *ics, int version_id)
 {
     int i;
-    ICSState *ics = opaque;
 
     for (i = 0; i < ics->icp->nr_servers; i++) {
         icp_resend(ics->icp, i);
@@ -402,6 +426,28 @@ static int ics_post_load(void *opaque, int version_id)
     return 0;
 }
 
+static void ics_dispatch_pre_save(void *opaque)
+{
+    ICSState *ics = opaque;
+    ICSStateClass *info = ICS_GET_CLASS(ics);
+
+    if (info->pre_save) {
+        info->pre_save(ics);
+    }
+}
+
+static int ics_dispatch_post_load(void *opaque, int version_id)
+{
+    ICSState *ics = opaque;
+    ICSStateClass *info = ICS_GET_CLASS(ics);
+
+    if (info->post_load) {
+        return info->post_load(ics, version_id);
+    }
+
+    return 0;
+}
+
 static const VMStateDescription vmstate_ics_irq = {
     .name = "ics/irq",
     .version_id = 1,
@@ -421,7 +467,8 @@ static const VMStateDescription vmstate_ics = {
     .version_id = 1,
     .minimum_version_id = 1,
     .minimum_version_id_old = 1,
-    .post_load = ics_post_load,
+    .pre_save = ics_dispatch_pre_save,
+    .post_load = ics_dispatch_post_load,
     .fields      = (VMStateField []) {
         /* Sanity check */
         VMSTATE_UINT32_EQUAL(nr_irqs, ICSState),
@@ -446,10 +493,12 @@ static int ics_realize(DeviceState *dev)
 static void ics_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
+    ICSStateClass *isc = ICS_CLASS(klass);
 
     dc->init = ics_realize;
     dc->vmsd = &vmstate_ics;
     dc->reset = ics_reset;
+    isc->post_load = ics_post_load;
 }
 
 static TypeInfo ics_info = {
@@ -457,6 +506,7 @@ static TypeInfo ics_info = {
     .parent = TYPE_DEVICE,
     .instance_size = sizeof(ICSState),
     .class_init = ics_class_init,
+    .class_size = sizeof(ICSStateClass),
 };
 
 /*
diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
index 66364c5..6e3b605 100644
--- a/include/hw/ppc/xics.h
+++ b/include/hw/ppc/xics.h
@@ -42,7 +42,9 @@
  *  that yet)
  */
 typedef struct XICSState XICSState;
+typedef struct ICPStateClass ICPStateClass;
 typedef struct ICPState ICPState;
+typedef struct ICSStateClass ICSStateClass;
 typedef struct ICSState ICSState;
 typedef struct ICSIRQState ICSIRQState;
 
@@ -59,6 +61,18 @@ struct XICSState {
 #define TYPE_ICP "icp"
 #define ICP(obj) OBJECT_CHECK(ICPState, (obj), TYPE_ICP)
 
+#define ICP_CLASS(klass) \
+     OBJECT_CLASS_CHECK(ICPStateClass, (klass), TYPE_ICP)
+#define ICP_GET_CLASS(obj) \
+     OBJECT_GET_CLASS(ICPStateClass, (obj), TYPE_ICP)
+
+struct ICPStateClass {
+    DeviceClass parent_class;
+
+    void (*pre_save)(ICPState *s);
+    int (*post_load)(ICPState *s, int version_id);
+};
+
 struct ICPState {
     /*< private >*/
     DeviceState parent_obj;
@@ -72,6 +86,18 @@ struct ICPState {
 #define TYPE_ICS "ics"
 #define ICS(obj) OBJECT_CHECK(ICSState, (obj), TYPE_ICS)
 
+#define ICS_CLASS(klass) \
+     OBJECT_CLASS_CHECK(ICSStateClass, (klass), TYPE_ICS)
+#define ICS_GET_CLASS(obj) \
+     OBJECT_GET_CLASS(ICSStateClass, (obj), TYPE_ICS)
+
+struct ICSStateClass {
+    DeviceClass parent_class;
+
+    void (*pre_save)(ICSState *s);
+    int (*post_load)(ICSState *s, int version_id);
+};
+
 struct ICSState {
     /*< private >*/
     DeviceState parent_obj;
-- 
1.8.1.4

  parent reply	other threads:[~2013-10-25 21:28 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-25 21:27 [Qemu-devel] [PULL 00/29] ppc patch queue 2013-10-25 Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 01/29] pseries: Update SLOF firmware image Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 02/29] pseries: Fix loading of little endian kernels Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 03/29] ppc: Add CFAR, DAR and DSISR to the dictionary of printable registers Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 04/29] target-ppc: Little Endian Correction to Load/Store Vector Element Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 05/29] PPC: Fix L2CR write accesses Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 06/29] spapr: increase temporary fdt buffer size Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 07/29] spapr: Add ibm, purr property on power7 and newer Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 08/29] spapr-rtas: fix h_rtas parameters reading Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 09/29] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 10/29] xics: move reset and cpu_setup Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 11/29] spapr: move cpu_setup after kvmppc_set_papr Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 12/29] xics: replace fprintf with error_report Alexander Graf
2013-10-25 21:27 ` Alexander Graf [this message]
2013-10-25 21:27 ` [Qemu-devel] [PULL 14/29] xics: convert init() to realize() Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 15/29] xics: add missing const specifiers to TypeInfo Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 16/29] xics: split to xics and xics-common Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 17/29] xics: add cpu_setup callback Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 18/29] xics-kvm: Support for in-kernel XICS interrupt controller Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 19/29] xics: Implement H_IPOLL Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 20/29] xics: Implement H_XIRR_X Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 21/29] xics-kvm: enable irqfd for MSI Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 22/29] spapr-pci: enable irqfd for INTx Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 23/29] target-ppc: Update slb array with correct index values Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 24/29] target-ppc: Check for error on address translation in memsave command Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 25/29] target-ppc: Use #define for max slb entries Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 26/29] dump-guest-memory: Check for the correct return value Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 27/29] target-ppc: dump-guest-memory support Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 28/29] target-ppc: Fill in OpenFirmware names for some PowerPCCPU families Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 29/29] spapr: Use DeviceClass::fw_name for device tree CPU node Alexander Graf
2013-10-25 22:59 ` [Qemu-devel] [Qemu-ppc] [PULL 00/29] ppc patch queue 2013-10-25 Mark Cave-Ayland
2013-10-26  4:43   ` Alexander Graf
2013-10-26  9:03     ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382736474-32128-14-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=aliguori@amazon.com \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).