qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	"qemu-ppc@nongnu.org list:PowerPC" <qemu-ppc@nongnu.org>,
	Anthony Liguori <aliguori@amazon.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL 02/29] pseries: Fix loading of little endian kernels
Date: Fri, 25 Oct 2013 23:27:27 +0200	[thread overview]
Message-ID: <1382736474-32128-3-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1382736474-32128-1-git-send-email-agraf@suse.de>

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Try loading the kernel as little endian if it fails big endian.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reviewed-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/ppc/spapr.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 004184d..5bf6c3b 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -273,6 +273,7 @@ static void *spapr_create_fdt_skel(const char *cpu_model,
                                    hwaddr initrd_base,
                                    hwaddr initrd_size,
                                    hwaddr kernel_size,
+                                   bool little_endian,
                                    const char *boot_device,
                                    const char *kernel_cmdline,
                                    uint32_t epow_irq)
@@ -326,6 +327,9 @@ static void *spapr_create_fdt_skel(const char *cpu_model,
                               cpu_to_be64(kernel_size) };
 
         _FDT((fdt_property(fdt, "qemu,boot-kernel", &kprop, sizeof(kprop))));
+        if (little_endian) {
+            _FDT((fdt_property(fdt, "qemu,boot-kernel-le", NULL, 0)));
+        }
     }
     if (boot_device) {
         _FDT((fdt_property_string(fdt, "qemu,boot-device", boot_device)));
@@ -1102,6 +1106,7 @@ static void ppc_spapr_init(QEMUMachineInitArgs *args)
     uint32_t initrd_base = 0;
     long kernel_size = 0, initrd_size = 0;
     long load_limit, rtas_limit, fw_size;
+    bool kernel_le = false;
     char *filename;
 
     msi_supported = true;
@@ -1282,6 +1287,12 @@ static void ppc_spapr_init(QEMUMachineInitArgs *args)
         kernel_size = load_elf(kernel_filename, translate_kernel_address, NULL,
                                NULL, &lowaddr, NULL, 1, ELF_MACHINE, 0);
         if (kernel_size < 0) {
+            kernel_size = load_elf(kernel_filename,
+                                   translate_kernel_address, NULL,
+                                   NULL, &lowaddr, NULL, 0, ELF_MACHINE, 0);
+            kernel_le = kernel_size > 0;
+        }
+        if (kernel_size < 0) {
             kernel_size = load_image_targphys(kernel_filename,
                                               KERNEL_LOAD_ADDR,
                                               load_limit - KERNEL_LOAD_ADDR);
@@ -1331,7 +1342,7 @@ static void ppc_spapr_init(QEMUMachineInitArgs *args)
     /* Prepare the device tree */
     spapr->fdt_skel = spapr_create_fdt_skel(cpu_model,
                                             initrd_base, initrd_size,
-                                            kernel_size,
+                                            kernel_size, kernel_le,
                                             boot_device, kernel_cmdline,
                                             spapr->epow_irq);
     assert(spapr->fdt_skel != NULL);
-- 
1.8.1.4

  parent reply	other threads:[~2013-10-25 21:28 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-25 21:27 [Qemu-devel] [PULL 00/29] ppc patch queue 2013-10-25 Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 01/29] pseries: Update SLOF firmware image Alexander Graf
2013-10-25 21:27 ` Alexander Graf [this message]
2013-10-25 21:27 ` [Qemu-devel] [PULL 03/29] ppc: Add CFAR, DAR and DSISR to the dictionary of printable registers Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 04/29] target-ppc: Little Endian Correction to Load/Store Vector Element Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 05/29] PPC: Fix L2CR write accesses Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 06/29] spapr: increase temporary fdt buffer size Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 07/29] spapr: Add ibm, purr property on power7 and newer Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 08/29] spapr-rtas: fix h_rtas parameters reading Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 09/29] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 10/29] xics: move reset and cpu_setup Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 11/29] spapr: move cpu_setup after kvmppc_set_papr Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 12/29] xics: replace fprintf with error_report Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 13/29] xics: add pre_save/post_load dispatchers Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 14/29] xics: convert init() to realize() Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 15/29] xics: add missing const specifiers to TypeInfo Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 16/29] xics: split to xics and xics-common Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 17/29] xics: add cpu_setup callback Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 18/29] xics-kvm: Support for in-kernel XICS interrupt controller Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 19/29] xics: Implement H_IPOLL Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 20/29] xics: Implement H_XIRR_X Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 21/29] xics-kvm: enable irqfd for MSI Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 22/29] spapr-pci: enable irqfd for INTx Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 23/29] target-ppc: Update slb array with correct index values Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 24/29] target-ppc: Check for error on address translation in memsave command Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 25/29] target-ppc: Use #define for max slb entries Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 26/29] dump-guest-memory: Check for the correct return value Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 27/29] target-ppc: dump-guest-memory support Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 28/29] target-ppc: Fill in OpenFirmware names for some PowerPCCPU families Alexander Graf
2013-10-25 21:27 ` [Qemu-devel] [PULL 29/29] spapr: Use DeviceClass::fw_name for device tree CPU node Alexander Graf
2013-10-25 22:59 ` [Qemu-devel] [Qemu-ppc] [PULL 00/29] ppc patch queue 2013-10-25 Mark Cave-Ayland
2013-10-26  4:43   ` Alexander Graf
2013-10-26  9:03     ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382736474-32128-3-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=aliguori@amazon.com \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).