From: Gerd Hoffmann <kraxel@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Yanqiangjun <yanqiangjun@huawei.com>,
Luonengjun <luonengjun@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Huangweidong (Hardware)" <huangweidong@huawei.com>
Subject: Re: [Qemu-devel] [PATCH] vnc: Fix qemu crash on vnc client disconnection
Date: Mon, 28 Oct 2013 08:52:47 +0100 [thread overview]
Message-ID: <1382946767.3767.1.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020815A091D@SZXEMA503-MBS.china.huawei.com>
Hi,
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 5601cc3..2177704 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -876,7 +876,8 @@ static int find_and_clear_dirty_height(struct VncState *vs,
> static int vnc_update_client_sync(VncState *vs, int has_dirty)
> {
> int ret = vnc_update_client(vs, has_dirty);
> - vnc_jobs_join(vs);
> + if (ret >= 0)
> + vnc_jobs_join(vs);
What happens with any running jobs if you skip the jouin call here?
cheers,
Gerd
next prev parent reply other threads:[~2013-10-28 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 5:14 [Qemu-devel] [PATCH] vnc: Fix qemu crash on vnc client disconnection Gonglei (Arei)
2013-10-28 7:52 ` Gerd Hoffmann [this message]
2013-10-28 8:47 ` Gonglei (Arei)
2013-11-04 12:50 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2013-10-28 7:50 Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382946767.3767.1.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=huangweidong@huawei.com \
--cc=luonengjun@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=yanqiangjun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).