From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbTd8-0002eD-Qd for qemu-devel@nongnu.org; Wed, 30 Oct 2013 07:08:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbTd2-0002X5-NX for qemu-devel@nongnu.org; Wed, 30 Oct 2013 07:08:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbTd2-0002Wt-Fe for qemu-devel@nongnu.org; Wed, 30 Oct 2013 07:08:00 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9UB7xw7007459 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 30 Oct 2013 07:07:59 -0400 Message-ID: <1383131275.22559.8.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 30 Oct 2013 12:07:55 +0100 In-Reply-To: <526AF64E.6040404@redhat.com> References: <20131024211158.064049176@amt.cnet> <20131024211249.723543071@amt.cnet> <5269B378.6040409@redhat.com> <20131025045805.GA18280@amt.cnet> <526A3152.2020603@redhat.com> <20131025195032.GA6391@amt.cnet> <526AF64E.6040404@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [patch 2/2] i386: pc: align gpa<->hpa on 1GB boundary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aarcange@redhat.com, Marcelo Tosatti , qemu-devel@nongnu.org, gleb@redhat.com, "Michael S. Tsirkin" On Fr, 2013-10-25 at 23:53 +0100, Paolo Bonzini wrote: > Il 25/10/2013 20:50, Marcelo Tosatti ha scritto: > > On Fri, Oct 25, 2013 at 09:52:34AM +0100, Paolo Bonzini wrote: > >> Because offsets are zero, and lengths match the RAM block lengths, you > >> do not need any complication with aliasing. This still has to be done > >> only for new machine types. > > > > Not possible because you just wasted holesize bytes (if number of > > additional bytes due to huge page alignment is smaller than holesize, a > > new hugepage is required, which is not acceptable). > > Ok. Thanks for explaining---the patch seems good with the proper > compatibility option in the machine type. Please run the > guest_memory_dump_analysis test in autotest too. As the whole thing must depend on machine type anyway for live migration compatibility we can also simply change the memory split, i.e. map 2GB (-M q35) or 3GB (-M pc) below 4G instead of the odd sizes (2.75 / 3.5) we have now. cheers, Gerd