From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbVKM-00056m-SD for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:56:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbVKG-0008BM-TG for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:56:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbVKG-0008BD-Jq for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:56:44 -0400 From: armbru@redhat.com Date: Wed, 30 Oct 2013 13:56:38 +0100 Message-Id: <1383137800-2990-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v3 0/2] smbios nicer defaults for DMI type 1 (System) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: ehabkost@redhat.com, mst@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, lersek@redhat.com, afaerber@suse.de From: Markus Armbruster Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs, no version. Best SeaBIOS can do, but we can provide better defaults: manufacturer QEMU, product & version taken from QEMUMachine desc and name. This series used to be called "[PATCH v2 0/7] smbios cleanup & nicer defaults for type 1", but its cleanup parts [0-5/7] already went in. Andreas didn't like "[PATCH v2 6/7] vl: Set current_machine early", and suggested to put he machine into QEMUMachineInitArgs. PATCH 1/2 does exactly that, replacing v2's PATCH 6/7. PATCH 2/2 is v2's PATCH 7/7 rebased on top. Michael didn't like the way I suppress the nicer defaults for old machine types via static bool smbios_type1_defaults, and thought it would be nicer to have it in QEMUMachine or some device. I considered this, but decided to stick to smbios_type1_defaults, because 1. There is no suitable device. 2. I'd rather not extend QEMUMachine with target-specific stuff. 3. A static bool whose default value gets flipped by some QEMUMachine init() methods is what we commonly do in such cases, so let's stick to that. v3: Do it the way Andreas suggested v2: Rebase, only last patch had conflicts Markus Armbruster (2): hw: Pass QEMUMachine to its init() method smbios: Set system manufacturer, product & version by default hw/i386/pc_piix.c | 9 +++++++++ hw/i386/pc_q35.c | 7 +++++++ hw/i386/smbios.c | 14 ++++++++++++++ include/hw/boards.h | 7 +++++-- include/hw/i386/smbios.h | 2 ++ vl.c | 3 ++- 6 files changed, 39 insertions(+), 3 deletions(-) -- 1.8.1.4