From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbYdg-0000P5-O5 for qemu-devel@nongnu.org; Wed, 30 Oct 2013 12:29:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbYdZ-0005gK-1U for qemu-devel@nongnu.org; Wed, 30 Oct 2013 12:29:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbYdY-0005ft-Pk for qemu-devel@nongnu.org; Wed, 30 Oct 2013 12:28:52 -0400 From: armbru@redhat.com Date: Wed, 30 Oct 2013 17:28:38 +0100 Message-Id: <1383150524-16250-5-git-send-email-armbru@redhat.com> In-Reply-To: <1383150524-16250-1-git-send-email-armbru@redhat.com> References: <1383150524-16250-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v3 04/10] apic: Document why cannot_instantiate_with_device_add_yet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, marcel.a@redhat.com, borntraeger@de.ibm.com, aliguori@amazon.com, afaerber@suse.de From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell --- hw/intc/apic_common.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index ea420c7..aaef054 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -386,9 +386,13 @@ static void apic_common_class_init(ObjectClass *klass, void *data) dc->vmsd = &vmstate_apic_common; dc->reset = apic_reset_common; - dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */ dc->props = apic_properties_common; idc->init = apic_init_common; + /* + * Reason: APIC and CPU need to be wired up by + * x86_cpu_apic_create() + */ + dc->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo apic_common_type = { -- 1.8.1.4