From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VdGnp-0000ur-Hx
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 04:50:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VdGnj-0003uh-IQ
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 04:50:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46009)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VdGnj-0003uZ-AA
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 04:50:27 -0500
Message-ID: <1383558557.8610.23.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 04 Nov 2013 10:49:17 +0100
In-Reply-To: <1383497154-9271-1-git-send-email-aliguori@amazon.com>
References: <1383497154-9271-1-git-send-email-aliguori@amazon.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Andreas Faerber <afaerber@suse.de>

On So, 2013-11-03 at 08:45 -0800, Anthony Liguori wrote:
> Modern Linux's no longer support /dev/dsp so enabling it by
> default causes audio failures on newer Linux distros.

That will break sound on BSD.

I think we should do something like this instead:

--- a/configure
+++ b/configure
@@ -554,7 +554,7 @@ Haiku)
   LIBS="-lposix_error_mapper -lnetwork $LIBS"
 ;;
 *)
-  audio_drv_list="oss"
+  audio_drv_list="pa alsa oss"
   audio_possible_drivers="oss alsa sdl esd pa"
   linux="yes"
   linux_user="yes"

i.e. build pulseaudio and alsa by default on linux and prioritize them
over oss.

cheers,
  Gerd