qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PATCH 2/2] pc: register e820 entries for ram
Date: Mon,  4 Nov 2013 13:17:11 +0100	[thread overview]
Message-ID: <1383567431-13540-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1383567431-13540-1-git-send-email-kraxel@redhat.com>

So RAM shows up in the new etc/e820 fw_cfg file.

Cc: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/i386/pc.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index a653ae4..12c436e 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1174,13 +1174,7 @@ FWCfgState *pc_memory_init(MemoryRegion *system_memory,
     memory_region_init_alias(ram_below_4g, NULL, "ram-below-4g", ram,
                              0, below_4g_mem_size);
     memory_region_add_subregion(system_memory, 0, ram_below_4g);
-    if (0) {
-        /*
-         * Ideally we should do that too, but that would ruin the e820
-         * reservations added by seabios before initializing fw_cfg.
-         */
-        e820_add_entry(0, below_4g_mem_size, E820_RAM);
-    }
+    e820_add_entry(0, below_4g_mem_size, E820_RAM);
     if (above_4g_mem_size > 0) {
         ram_above_4g = g_malloc(sizeof(*ram_above_4g));
         memory_region_init_alias(ram_above_4g, NULL, "ram-above-4g", ram,
-- 
1.8.3.1

  parent reply	other threads:[~2013-11-04 12:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04 12:17 [Qemu-devel] [PULL for-1.7 0/2] pc: e820 fw_cfg fixup Gerd Hoffmann
2013-11-04 12:17 ` [Qemu-devel] [PATCH 1/2] pc: add etc/e820 fw_cfg file Gerd Hoffmann
2013-11-05 17:48   ` Andrea Arcangeli
2013-11-06  7:54     ` Gerd Hoffmann
2013-11-04 12:17 ` Gerd Hoffmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-10-22 14:05 [Qemu-devel] [PATCH v2 0/2] fw_cfg: add etc/e820 Gerd Hoffmann
2013-10-22 14:05 ` [Qemu-devel] [PATCH 2/2] pc: register e820 entries for ram Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383567431-13540-3-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).