From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdJSm-0006gN-7F for qemu-devel@nongnu.org; Mon, 04 Nov 2013 07:41:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdJSg-0005t3-6a for qemu-devel@nongnu.org; Mon, 04 Nov 2013 07:41:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdJSf-0005sy-Uv for qemu-devel@nongnu.org; Mon, 04 Nov 2013 07:40:54 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA4CeqMX002321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 4 Nov 2013 07:40:53 -0500 Message-ID: <1383568850.8610.31.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Mon, 04 Nov 2013 13:40:50 +0100 In-Reply-To: <1383212131-10346-1-git-send-email-hdegoede@redhat.com> References: <1383212131-10346-1-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] uas: Fix response iu struct definition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: qemu-devel@nongnu.org On Do, 2013-10-31 at 10:35 +0100, Hans de Goede wrote: > This patch mirrors a patch to the Linux uas kernel driver which I've just > submitted. It looks like the qemu uas struct definitions were taken from > the Linux kernel driver, and have inherited the same mistake. > > Besides fixing the response iu struct, the patch also drops the add_info > parameter from the usb_uas_queue_response() function, it is always 0 anyways, > and expressing 3 zero-bytes as a function argument is a bit hard. Added to usb patch queue, together with the other uas patch series. thanks, Gerd