From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdKW7-0005BF-2X for qemu-devel@nongnu.org; Mon, 04 Nov 2013 08:48:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdKW2-0007MV-KU for qemu-devel@nongnu.org; Mon, 04 Nov 2013 08:48:31 -0500 Date: Mon, 4 Nov 2013 15:51:13 +0200 From: "Michael S. Tsirkin" Message-ID: <1383572851-28326-3-git-send-email-mst@redhat.com> References: <1383572851-28326-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1383572851-28326-1-git-send-email-mst@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 2/3] exec: limit system memory size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-stable@nongnu.org, =?us-ascii?B?PT9VVEYtOD9xP0FuZHJlYXM9MjBGPUMzPUE0cmJlcj89?= The page table logic in exec.c assumes that memory addresses are at most TARGET_PHYS_ADDR_SPACE_BITS. But pci addresses are full 64 bit so if we try to render them ignoring the extra bits, we get strange effects with sections overlapping each other. To fix, simply limit the system memory size to 1 << TARGET_PHYS_ADDR_SPACE_BITS, pci addresses will be rendered within that. Cc: qemu-stable@nongnu.org Reported-by: Andreas F=E4rber Reviewed-by: Paolo Bonzini Signed-off-by: Michael S. Tsirkin --- exec.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index b453713..79610ce 100644 --- a/exec.c +++ b/exec.c @@ -1741,7 +1741,12 @@ void address_space_destroy_dispatch(AddressSpace *= as) static void memory_map_init(void) { system_memory =3D g_malloc(sizeof(*system_memory)); - memory_region_init(system_memory, NULL, "system", INT64_MAX); + + assert(TARGET_PHYS_ADDR_SPACE_BITS <=3D 64); + + memory_region_init(system_memory, NULL, "system", + TARGET_PHYS_ADDR_SPACE_BITS =3D=3D 64 ? + UINT64_MAX : (0x1ULL << TARGET_PHYS_ADDR_SPACE_BI= TS)); address_space_init(&address_space_memory, system_memory, "memory"); =20 system_io =3D g_malloc(sizeof(*system_io)); --=20 MST