From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdbaJ-0007eq-G4 for qemu-devel@nongnu.org; Tue, 05 Nov 2013 03:02:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vdba9-0002L0-GU for qemu-devel@nongnu.org; Tue, 05 Nov 2013 03:01:59 -0500 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:43999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdba8-0002KN-TR for qemu-devel@nongnu.org; Tue, 05 Nov 2013 03:01:49 -0500 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Nov 2013 13:31:42 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 88C06E0058 for ; Tue, 5 Nov 2013 13:33:23 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rA581YsR25624742 for ; Tue, 5 Nov 2013 13:31:35 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rA581akR008773 for ; Tue, 5 Nov 2013 13:31:37 +0530 From: Wenchao Xia Date: Tue, 5 Nov 2013 08:01:23 +0800 Message-Id: <1383609689-4417-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V5 0/6] qcow2: rollback the modification on fail in snapshot creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@gmail.com, mreitz@redhat.com, pbonzini@redhat.com, Wenchao Xia V2: 1: all fail case will goto fail section. 2: add the goto code. v3: Address Stefan's comments: 2: don't goto fail after allocation failure. 3: use sn->l1size correctly in qcow2_free_cluster(). 4-7: add test case to verify the error paths. Other: 1: new patch fix a existing bug, which will be exposed in error path test. v4: General change: rebased on upstream since error path for qcow2_write_snapshots() already exist in upstream. removed old patch 1 since it is fixed by Max in upstream. 5: moved the snapshot_l1_update event just before write operation, instead of before overlap check, since it is more straight. 6: remove a duplicated error path test about flush after snapshot list update, add a filter which replace number to X, since now in error in report detailed message including error cluster number. Address Stefan's comments: 1, 2, 4: add *errp to store detailed error message, instead of error_report() and compile time determined debug printf message. 3: do not free cluster when fail in header update for safety reason. Address Eric's comments: 1, 2, 4: add *errp to store detailed error message, instead of error_report() and compile time determined debug printf message. 5: squashed patches that add and use debug events. 6: added comments about test only on Linux. v5: General change: 6: rebased on upstream, use case number 070, adjust 070.out due to error message change in this version. Address Max's comments: 1 use error_setg_errno() when possible, remove "ret =" in functions when possible since the function does not need to return int value, fix 32bit/ 64bit issue in printf for "sizeof" and "offse", typo fix. 2 use error_setg_errno() when possible, fix 32bit/64bit issue in printf for "sizeof" and "offse", typo fix. 3 typo fix in comments. 5 typo fix in commit message. Address Eric's comments: 2 fix 32bit/64bit issue in printf for "sizeof" and "offse". Wenchao Xia (6): 1 snapshot: add parameter *errp in snapshot create 2 qcow2: add error message in qcow2_write_snapshots() 3 qcow2: do not free clusters when fail in header update in qcow2_write_snapshots 4 qcow2: cancel the modification on fail in qcow2_snapshot_create() 5 blkdebug: add debug events for snapshot 6 qemu-iotests: add test for qcow2 snapshot block/blkdebug.c | 4 + block/qcow2-snapshot.c | 105 ++++++++++++++++--- block/qcow2.h | 4 +- block/rbd.c | 19 ++-- block/sheepdog.c | 28 +++-- block/snapshot.c | 19 +++- blockdev.c | 10 +- include/block/block.h | 4 + include/block/block_int.h | 5 +- include/block/snapshot.h | 5 +- qemu-img.c | 10 +- savevm.c | 12 ++- tests/qemu-iotests/070 | 214 ++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/070.out | 35 ++++++ tests/qemu-iotests/common.filter | 7 ++ tests/qemu-iotests/group | 1 + 16 files changed, 425 insertions(+), 57 deletions(-) create mode 100755 tests/qemu-iotests/070 create mode 100644 tests/qemu-iotests/070.out