From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdiW0-0000P6-D1 for qemu-devel@nongnu.org; Tue, 05 Nov 2013 10:26:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdiVt-0006Qz-TK for qemu-devel@nongnu.org; Tue, 05 Nov 2013 10:26:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdiVt-0006Qn-LL for qemu-devel@nongnu.org; Tue, 05 Nov 2013 10:25:53 -0500 Message-ID: <1383665150.22581.31.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 05 Nov 2013 16:25:50 +0100 In-Reply-To: <1383664554-15248-1-git-send-email-marcandre.lureau@gmail.com> References: <1383664554-15248-1-git-send-email-marcandre.lureau@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.7] vga: fix invalid read after free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau Cc: qemu-devel@nongnu.org On Di, 2013-11-05 at 16:15 +0100, Marc-Andr=C3=A9 Lureau wrote: > --- a/hw/display/vga.c > +++ b/hw/display/vga.c > @@ -1707,7 +1707,6 @@ static void vga_draw_graphic(VGACommonState *s, > int full_update) > } else if (is_buffer_shared(surface) && > (full_update || surface_data(surface) !=3D s->vram_ptr > + (s->start_addr * 4))) { > - DisplaySurface *surface; > surface =3D qemu_create_displaysurface_from(disp_width, > height, depth, s->line_offset, > s->vram_ptr + (s->start_addr * 4), byteswap); Reviewed-by: Gerd Hoffmann cheers, Gerd