From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
patches@linaro.org, Stefan Hajnoczi <stefanha@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v2 9/9] bswap.h: Remove cpu_to_32wu()
Date: Tue, 5 Nov 2013 16:38:37 +0000 [thread overview]
Message-ID: <1383669517-25598-10-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1383669517-25598-1-git-send-email-peter.maydell@linaro.org>
Replace the legacy cpu_to_32wu() with stl_p().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/display/vga_template.h | 14 ++++++++------
include/qemu/bswap.h | 7 -------
2 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/hw/display/vga_template.h b/hw/display/vga_template.h
index f6f6a01..6cfae56 100644
--- a/hw/display/vga_template.h
+++ b/hw/display/vga_template.h
@@ -113,20 +113,22 @@ static void glue(vga_draw_glyph9_, DEPTH)(uint8_t *d, int linesize,
do {
font_data = font_ptr[0];
#if BPP == 1
- cpu_to_32wu((uint32_t *)d, (dmask16[(font_data >> 4)] & xorcol) ^ bgcol);
+ stl_p((uint32_t *)d, (dmask16[(font_data >> 4)] & xorcol) ^ bgcol);
v = (dmask16[(font_data >> 0) & 0xf] & xorcol) ^ bgcol;
- cpu_to_32wu(((uint32_t *)d)+1, v);
+ stl_p(((uint32_t *)d)+1, v);
if (dup9)
((uint8_t *)d)[8] = v >> (24 * (1 - BIG));
else
((uint8_t *)d)[8] = bgcol;
#elif BPP == 2
- cpu_to_32wu(((uint32_t *)d)+0, (dmask4[(font_data >> 6)] & xorcol) ^ bgcol);
- cpu_to_32wu(((uint32_t *)d)+1, (dmask4[(font_data >> 4) & 3] & xorcol) ^ bgcol);
- cpu_to_32wu(((uint32_t *)d)+2, (dmask4[(font_data >> 2) & 3] & xorcol) ^ bgcol);
+ stl_p(((uint32_t *)d)+0, (dmask4[(font_data >> 6)] & xorcol) ^ bgcol);
+ stl_p(((uint32_t *)d)+1,
+ (dmask4[(font_data >> 4) & 3] & xorcol) ^ bgcol);
+ stl_p(((uint32_t *)d)+2,
+ (dmask4[(font_data >> 2) & 3] & xorcol) ^ bgcol);
v = (dmask4[(font_data >> 0) & 3] & xorcol) ^ bgcol;
- cpu_to_32wu(((uint32_t *)d)+3, v);
+ stl_p(((uint32_t *)d)+3, v);
if (dup9)
((uint16_t *)d)[8] = v >> (16 * (1 - BIG));
else
diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
index 4cbd6e7..437b8e0 100644
--- a/include/qemu/bswap.h
+++ b/include/qemu/bswap.h
@@ -410,13 +410,6 @@ static inline void stfq_be_p(void *ptr, float64 v)
stq_be_p(ptr, u.ll);
}
-/* Legacy unaligned versions. Note that we never had a complete set. */
-
-static inline void cpu_to_32wu(uint32_t *p, uint32_t v)
-{
- stl_p(p, v);
-}
-
static inline unsigned long leul_to_cpu(unsigned long v)
{
/* In order to break an include loop between here and
--
1.7.9.5
next prev parent reply other threads:[~2013-11-05 16:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 16:38 [Qemu-devel] [PATCH v2 0/9] Remove legacy unaligned bswap functions Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 1/9] bswap.h: Remove cpu_to_le16wu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 2/9] bswap.h: Remove cpu_to_le32wu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 3/9] bswap.h: Remove le16_to_cpupu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 4/9] bswap.h: Remove le32_to_cpupu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 5/9] bswap.h: Remove be32_to_cpupu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 6/9] bswap.h: Remove cpu_to_be16wu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 7/9] bswap.h: Remove cpu_to_be32wu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 8/9] bswap.h: Remove cpu_to_be64wu() Peter Maydell
2013-11-05 16:38 ` Peter Maydell [this message]
2013-11-05 19:06 ` [Qemu-devel] [PATCH v2 0/9] Remove legacy unaligned bswap functions Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383669517-25598-10-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=aliguori@amazon.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).