From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
patches@linaro.org, Stefan Hajnoczi <stefanha@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v2 2/9] bswap.h: Remove cpu_to_le32wu()
Date: Tue, 5 Nov 2013 16:38:30 +0000 [thread overview]
Message-ID: <1383669517-25598-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1383669517-25598-1-git-send-email-peter.maydell@linaro.org>
Replace the legacy cpu_to_le32wu() with stl_le_p().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/net/ne2000.c | 2 +-
include/hw/pci/pci.h | 2 +-
include/qemu/bswap.h | 5 -----
3 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
index a94cf74..9ba3d1e 100644
--- a/hw/net/ne2000.c
+++ b/hw/net/ne2000.c
@@ -467,7 +467,7 @@ static inline void ne2000_mem_writel(NE2000State *s, uint32_t addr,
addr &= ~1; /* XXX: check exact behaviour if not even */
if (addr < 32 ||
(addr >= NE2000_PMEM_START && addr < NE2000_MEM_SIZE)) {
- cpu_to_le32wu((uint32_t *)(s->mem + addr), val);
+ stl_le_p(s->mem + addr, val);
}
}
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index fae2170..9cd0642 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -433,7 +433,7 @@ pci_get_word(const uint8_t *config)
static inline void
pci_set_long(uint8_t *config, uint32_t val)
{
- cpu_to_le32wu((uint32_t *)config, val);
+ stl_le_p(config, val);
}
static inline uint32_t
diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
index ada1084..d0c4ff0 100644
--- a/include/qemu/bswap.h
+++ b/include/qemu/bswap.h
@@ -412,11 +412,6 @@ static inline void stfq_be_p(void *ptr, float64 v)
/* Legacy unaligned versions. Note that we never had a complete set. */
-static inline void cpu_to_le32wu(uint32_t *p, uint32_t v)
-{
- stl_le_p(p, v);
-}
-
static inline uint16_t le16_to_cpupu(const uint16_t *p)
{
return lduw_le_p(p);
--
1.7.9.5
next prev parent reply other threads:[~2013-11-05 16:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 16:38 [Qemu-devel] [PATCH v2 0/9] Remove legacy unaligned bswap functions Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 1/9] bswap.h: Remove cpu_to_le16wu() Peter Maydell
2013-11-05 16:38 ` Peter Maydell [this message]
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 3/9] bswap.h: Remove le16_to_cpupu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 4/9] bswap.h: Remove le32_to_cpupu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 5/9] bswap.h: Remove be32_to_cpupu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 6/9] bswap.h: Remove cpu_to_be16wu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 7/9] bswap.h: Remove cpu_to_be32wu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 8/9] bswap.h: Remove cpu_to_be64wu() Peter Maydell
2013-11-05 16:38 ` [Qemu-devel] [PATCH v2 9/9] bswap.h: Remove cpu_to_32wu() Peter Maydell
2013-11-05 19:06 ` [Qemu-devel] [PATCH v2 0/9] Remove legacy unaligned bswap functions Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383669517-25598-3-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=aliguori@amazon.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).