From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdtVi-0006dd-3a for qemu-devel@nongnu.org; Tue, 05 Nov 2013 22:10:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdtVZ-0003Op-NV for qemu-devel@nongnu.org; Tue, 05 Nov 2013 22:10:26 -0500 Received: from mail-oa0-x236.google.com ([2607:f8b0:4003:c02::236]:62895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdtVZ-0003Ol-IR for qemu-devel@nongnu.org; Tue, 05 Nov 2013 22:10:17 -0500 Received: by mail-oa0-f54.google.com with SMTP id n16so1566434oag.13 for ; Tue, 05 Nov 2013 19:10:17 -0800 (PST) From: Xu Wang Date: Tue, 5 Nov 2013 22:09:21 -0500 Message-Id: <1383707361-19580-6-git-send-email-gesaint@linux.vnet.ibm.com> In-Reply-To: <1383707361-19580-1-git-send-email-gesaint@linux.vnet.ibm.com> References: <1383707361-19580-1-git-send-email-gesaint@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V6 5/5] blockdev: Add infinite loop check in drive_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, Xu Wang , wdongxu@linux.vnet.ibm.com, xiawenc@linux.vnet.ibm.com Check the backing file for a loop during image boot, to avoid a lack or response or segfault. Signed-off-by: Xu Wang --- blockdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/blockdev.c b/blockdev.c index b260477..7c0927f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -510,6 +510,12 @@ static DriveInfo *blockdev_init(QDict *bs_opts, bdrv_flags |= ro ? 0 : BDRV_O_RDWR; + /* Add backing file loop check */ + if (!bdrv_backing_chain_okay(file, drv ? drv->format_name : NULL)) { + error_report("drive_init: backing file loop check failed"); + goto err; + } + QINCREF(bs_opts); ret = bdrv_open(dinfo->bdrv, file, bs_opts, bdrv_flags, drv, &error); -- 1.8.1.4