From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve2na-00026V-H7 for qemu-devel@nongnu.org; Wed, 06 Nov 2013 08:05:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve2nU-0004wI-6y for qemu-devel@nongnu.org; Wed, 06 Nov 2013 08:05:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve2nT-0004w5-Vr for qemu-devel@nongnu.org; Wed, 06 Nov 2013 08:05:24 -0500 From: Juan Quintela Date: Wed, 6 Nov 2013 14:04:33 +0100 Message-Id: <1383743088-8139-25-git-send-email-quintela@redhat.com> In-Reply-To: <1383743088-8139-1-git-send-email-quintela@redhat.com> References: <1383743088-8139-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 24/39] memory: cpu_physical_memory_get_dirty() is used as returning a bool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: chegu_vinod@hp.com Signed-off-by: Juan Quintela --- include/exec/memory-internal.h | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index f66d2ce..de8f279 100644 --- a/include/exec/memory-internal.h +++ b/include/exec/memory-internal.h @@ -40,11 +40,10 @@ void *qemu_get_ram_ptr(ram_addr_t addr); void qemu_ram_free(ram_addr_t addr); void qemu_ram_free_from_ptr(ram_addr_t addr); -static inline int cpu_physical_memory_get_dirty(ram_addr_t start, - ram_addr_t length, - unsigned client) +static inline bool cpu_physical_memory_get_dirty(ram_addr_t start, + ram_addr_t length, + unsigned client) { - int ret = 0; ram_addr_t addr, end; assert(client < DIRTY_MEMORY_NUM); @@ -52,9 +51,11 @@ static inline int cpu_physical_memory_get_dirty(ram_addr_t start, end = TARGET_PAGE_ALIGN(start + length); start &= TARGET_PAGE_MASK; for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { - ret |= test_bit(addr >> TARGET_PAGE_BITS, ram_list.dirty_memory[client]); + if (test_bit(addr >> TARGET_PAGE_BITS, ram_list.dirty_memory[client])) { + return true; + } } - return ret; + return false; } static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr, -- 1.8.3.1