From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve2nl-0002QD-H9 for qemu-devel@nongnu.org; Wed, 06 Nov 2013 08:05:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve2ne-0004zf-3P for qemu-devel@nongnu.org; Wed, 06 Nov 2013 08:05:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve2nd-0004z9-Ru for qemu-devel@nongnu.org; Wed, 06 Nov 2013 08:05:34 -0500 From: Juan Quintela Date: Wed, 6 Nov 2013 14:04:40 +0100 Message-Id: <1383743088-8139-32-git-send-email-quintela@redhat.com> In-Reply-To: <1383743088-8139-1-git-send-email-quintela@redhat.com> References: <1383743088-8139-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 31/39] memory: cpu_physical_memory_set_dirty_tracking() should return void List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: chegu_vinod@hp.com Result was always 0, and not used anywhere. Once there, use bool type for the parameter. Signed-off-by: Juan Quintela --- exec.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index 984b417..11b434b 100644 --- a/exec.c +++ b/exec.c @@ -54,7 +54,7 @@ //#define DEBUG_SUBPAGE #if !defined(CONFIG_USER_ONLY) -static int in_migration; +static bool in_migration; RAMList ram_list = { .blocks = QTAILQ_HEAD_INITIALIZER(ram_list.blocks) }; @@ -676,11 +676,9 @@ void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t length, } } -static int cpu_physical_memory_set_dirty_tracking(int enable) +static void cpu_physical_memory_set_dirty_tracking(bool enable) { - int ret = 0; in_migration = enable; - return ret; } hwaddr memory_region_section_get_iotlb(CPUArchState *env, @@ -1699,12 +1697,12 @@ static void tcg_commit(MemoryListener *listener) static void core_log_global_start(MemoryListener *listener) { - cpu_physical_memory_set_dirty_tracking(1); + cpu_physical_memory_set_dirty_tracking(true); } static void core_log_global_stop(MemoryListener *listener) { - cpu_physical_memory_set_dirty_tracking(0); + cpu_physical_memory_set_dirty_tracking(false); } static MemoryListener core_memory_listener = { -- 1.8.3.1