From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38759)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1Ve7UX-0007Mi-CV
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 13:06:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1Ve7US-0000GB-IV
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 13:06:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:19192)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1Ve7US-0000Fw-AS
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 13:06:04 -0500
Message-ID: <1383761161.21055.187.camel@ul30vt.home>
From: Alex Williamson <alex.williamson@redhat.com>
Date: Wed, 06 Nov 2013 11:06:01 -0700
In-Reply-To: <20131106073417.GQ7513@redhat.com>
References: <5277A45F.1070301@siemens.com> <20131106073417.GQ7513@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH uq/master] pci-assign: Remove dead code for
 direct I/O region access from userspace
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>

On Wed, 2013-11-06 at 09:34 +0200, Gleb Natapov wrote:
> Alex can you review please?

Yep, looks fine.

Acked-by: Alex Williamson <alex.williamson@redhat.com>

> On Mon, Nov 04, 2013 at 02:42:55PM +0100, Jan Kiszka wrote:
> > This feature was already deprecated back then in qemu-kvm, ie. before
> > pci-assign went upstream. assigned_dev_ioport_rw will never be invoked
> > with resource_fd < 0.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> >  hw/i386/kvm/pci-assign.c | 56 +++++++++---------------------------------------
> >  1 file changed, 10 insertions(+), 46 deletions(-)
> > 
> > diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
> > index 011764f..4e65110 100644
> > --- a/hw/i386/kvm/pci-assign.c
> > +++ b/hw/i386/kvm/pci-assign.c
> > @@ -154,55 +154,19 @@ static uint64_t assigned_dev_ioport_rw(AssignedDevRegion *dev_region,
> >      uint64_t val = 0;
> >      int fd = dev_region->region->resource_fd;
> >  
> > -    if (fd >= 0) {
> > -        if (data) {
> > -            DEBUG("pwrite data=%" PRIx64 ", size=%d, e_phys=" TARGET_FMT_plx
> > -                  ", addr="TARGET_FMT_plx"\n", *data, size, addr, addr);
> > -            if (pwrite(fd, data, size, addr) != size) {
> > -                error_report("%s - pwrite failed %s",
> > -                             __func__, strerror(errno));
> > -            }
> > -        } else {
> > -            if (pread(fd, &val, size, addr) != size) {
> > -                error_report("%s - pread failed %s",
> > -                             __func__, strerror(errno));
> > -                val = (1UL << (size * 8)) - 1;
> > -            }
> > -            DEBUG("pread val=%" PRIx64 ", size=%d, e_phys=" TARGET_FMT_plx
> > -                  ", addr=" TARGET_FMT_plx "\n", val, size, addr, addr);
> > +    if (data) {
> > +        DEBUG("pwrite data=%" PRIx64 ", size=%d, e_phys=" TARGET_FMT_plx
> > +              ", addr="TARGET_FMT_plx"\n", *data, size, addr, addr);
> > +        if (pwrite(fd, data, size, addr) != size) {
> > +            error_report("%s - pwrite failed %s", __func__, strerror(errno));
> >          }
> >      } else {
> > -        uint32_t port = addr + dev_region->u.r_baseport;
> > -
> > -        if (data) {
> > -            DEBUG("out data=%" PRIx64 ", size=%d, e_phys=" TARGET_FMT_plx
> > -                  ", host=%x\n", *data, size, addr, port);
> > -            switch (size) {
> > -            case 1:
> > -                outb(*data, port);
> > -                break;
> > -            case 2:
> > -                outw(*data, port);
> > -                break;
> > -            case 4:
> > -                outl(*data, port);
> > -                break;
> > -            }
> > -        } else {
> > -            switch (size) {
> > -            case 1:
> > -                val = inb(port);
> > -                break;
> > -            case 2:
> > -                val = inw(port);
> > -                break;
> > -            case 4:
> > -                val = inl(port);
> > -                break;
> > -            }
> > -            DEBUG("in data=%" PRIx64 ", size=%d, e_phys=" TARGET_FMT_plx
> > -                  ", host=%x\n", val, size, addr, port);
> > +        if (pread(fd, &val, size, addr) != size) {
> > +            error_report("%s - pread failed %s", __func__, strerror(errno));
> > +            val = (1UL << (size * 8)) - 1;
> >          }
> > +        DEBUG("pread val=%" PRIx64 ", size=%d, e_phys=" TARGET_FMT_plx
> > +              ", addr=" TARGET_FMT_plx "\n", val, size, addr, addr);
> >      }
> >      return val;
> >  }
> > -- 
> > 1.8.1.1.298.ge7eed54
> 
> --
> 			Gleb.