From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeE3g-0007WN-S4 for qemu-devel@nongnu.org; Wed, 06 Nov 2013 20:06:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeE3a-0006EP-VT for qemu-devel@nongnu.org; Wed, 06 Nov 2013 20:06:52 -0500 Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c]:61021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeE3a-0006EF-HJ for qemu-devel@nongnu.org; Wed, 06 Nov 2013 20:06:46 -0500 Received: by mail-pa0-f44.google.com with SMTP id fb1so483513pad.3 for ; Wed, 06 Nov 2013 17:06:45 -0800 (PST) Received: from pebble.com (CPE-138-130-249-46.lnse4.cha.bigpond.net.au. [138.130.249.46]) by mx.google.com with ESMTPSA id xs1sm1726198pac.7.2013.11.06.17.06.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Nov 2013 17:06:45 -0800 (PST) Sender: Richard Henderson From: Richard Henderson Date: Thu, 7 Nov 2013 11:04:39 +1000 Message-Id: <1383786324-18415-17-git-send-email-rth@twiddle.net> In-Reply-To: <1383786324-18415-1-git-send-email-rth@twiddle.net> References: <1383786324-18415-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH for-1.8 16/61] target-i386: Tidy movsl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Always perform a sign-extending load. In the extremely unlikely case that we've used an 0x66 prefix, the extension to 64-bits is unnecessary but not wrong; the store will still examine only 16 bits. Signed-off-by: Richard Henderson --- target-i386/translate.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 31e6d77..0f00fde 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -7740,11 +7740,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s, gen_op_mov_reg_T0(d_ot, reg); } else { gen_lea_modrm(env, s, modrm, ®_addr, &offset_addr); - if (d_ot == MO_64) { - gen_op_ld_v(s, MO_32 | MO_SIGN, cpu_T[0], cpu_A0); - } else { - gen_op_ld_v(s, MO_32, cpu_T[0], cpu_A0); - } + gen_op_ld_v(s, MO_32 | MO_SIGN, cpu_T[0], cpu_A0); gen_op_mov_reg_T0(d_ot, reg); } } else -- 1.8.3.1