From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeE3m-0007ec-8J for qemu-devel@nongnu.org; Wed, 06 Nov 2013 20:07:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeE3g-0006Fl-CC for qemu-devel@nongnu.org; Wed, 06 Nov 2013 20:06:58 -0500 Received: from mail-pd0-x22d.google.com ([2607:f8b0:400e:c02::22d]:51049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeE3f-0006Fd-MW for qemu-devel@nongnu.org; Wed, 06 Nov 2013 20:06:52 -0500 Received: by mail-pd0-f173.google.com with SMTP id r10so303911pdi.18 for ; Wed, 06 Nov 2013 17:06:50 -0800 (PST) Received: from pebble.com (CPE-138-130-249-46.lnse4.cha.bigpond.net.au. [138.130.249.46]) by mx.google.com with ESMTPSA id xs1sm1726198pac.7.2013.11.06.17.06.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Nov 2013 17:06:50 -0800 (PST) Sender: Richard Henderson From: Richard Henderson Date: Thu, 7 Nov 2013 11:04:41 +1000 Message-Id: <1383786324-18415-19-git-send-email-rth@twiddle.net> In-Reply-To: <1383786324-18415-1-git-send-email-rth@twiddle.net> References: <1383786324-18415-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH for-1.8 18/61] target-i386: Use MO_BE for movbe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Fold the bswap into the memory operation. Signed-off-by: Richard Henderson --- target-i386/translate.c | 40 +++++----------------------------------- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 714fb38..c433cc3 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -3869,44 +3869,14 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b, ot = MO_64; } - /* Load the data incoming to the bswap. Note that the TCG - implementation of bswap requires the input be zero - extended. In the case of the loads, we simply know that - gen_op_ld_v via gen_ldst_modrm does that already. */ - if ((b & 1) == 0) { - gen_ldst_modrm(env, s, modrm, ot, OR_TMP0, 0); - } else { - switch (ot) { - case MO_16: - tcg_gen_ext16u_tl(cpu_T[0], cpu_regs[reg]); - break; - default: - tcg_gen_ext32u_tl(cpu_T[0], cpu_regs[reg]); - break; - case MO_64: - tcg_gen_mov_tl(cpu_T[0], cpu_regs[reg]); - break; - } - } - - switch (ot) { - case MO_16: - tcg_gen_bswap16_tl(cpu_T[0], cpu_T[0]); - break; - default: - tcg_gen_bswap32_tl(cpu_T[0], cpu_T[0]); - break; -#ifdef TARGET_X86_64 - case MO_64: - tcg_gen_bswap64_tl(cpu_T[0], cpu_T[0]); - break; -#endif - } - + gen_lea_modrm(env, s, modrm); if ((b & 1) == 0) { + tcg_gen_qemu_ld_tl(cpu_T[0], cpu_A0, + s->mem_index, ot | MO_BE); gen_op_mov_reg_T0(ot, reg); } else { - gen_ldst_modrm(env, s, modrm, ot, OR_TMP0, 1); + tcg_gen_qemu_st_tl(cpu_regs[reg], cpu_A0, + s->mem_index, ot | MO_BE); } break; -- 1.8.3.1