From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@amazon.com>,
Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default
Date: Thu, 07 Nov 2013 12:33:20 +0100 [thread overview]
Message-ID: <1383824000.3511.3.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CA+aC4kstVK7PqFMuWC3PA-xv=QgF6yk4vs_fBzEqsPKf239W_A@mail.gmail.com>
Hi,
> And that is actually simple enough that we can consider it for 1.7:
> >
> > static void *oss_audio_init (void)
> > {
> > + if (access(conf.devpath_in, R_OK | W_OK) < 0 ||
> > + access(conf.devpath_out, R_OK | W_OK) < 0) {
> > + return NULL;
>
> That would be reasonable. Can you add a SoB and submit as a patch?
Pull req sent.
cheers,
Gerd
next prev parent reply other threads:[~2013-11-07 11:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-03 16:45 [Qemu-devel] [PATCH] ossaudio: do not enable by default Anthony Liguori
2013-11-03 17:12 ` Andreas Färber
2013-11-03 17:47 ` Anthony Liguori
2013-11-04 9:49 ` Gerd Hoffmann
2013-11-05 19:57 ` Anthony Liguori
2013-11-05 20:18 ` Peter Maydell
2013-11-05 20:34 ` Peter Maydell
2013-11-06 9:18 ` Gerd Hoffmann
2013-11-06 10:48 ` Peter Maydell
2013-11-06 11:15 ` Gerd Hoffmann
2013-11-06 14:54 ` Anthony Liguori
2013-11-06 15:00 ` Peter Maydell
2013-11-06 15:20 ` Gerd Hoffmann
2013-11-06 17:01 ` Anthony Liguori
2013-11-07 11:33 ` Gerd Hoffmann [this message]
2013-11-04 11:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383824000.3511.3.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=anthony@codemonkey.ws \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).