From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VePPs-00073G-De for qemu-devel@nongnu.org; Thu, 07 Nov 2013 08:14:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VePPl-0006D7-Ht for qemu-devel@nongnu.org; Thu, 07 Nov 2013 08:14:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35468) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VePPi-0006CY-BP for qemu-devel@nongnu.org; Thu, 07 Nov 2013 08:14:24 -0500 From: Stefan Hajnoczi Date: Thu, 7 Nov 2013 14:12:24 +0100 Message-Id: <1383829964-32364-17-git-send-email-stefanha@redhat.com> In-Reply-To: <1383829964-32364-1-git-send-email-stefanha@redhat.com> References: <1383829964-32364-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 16/36] block: Save errno before error_setg_errno List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Anthony Liguori , Max Reitz From: Max Reitz error_setg_errno() may overwrite errno; therefore, its value should be read before calling that function and not afterwards. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 58efb5b..0e96a22 100644 --- a/block.c +++ b/block.c @@ -1084,8 +1084,8 @@ int bdrv_open(BlockDriverState *bs, const char *filename, QDict *options, snprintf(backing_filename, sizeof(backing_filename), "%s", filename); } else if (!realpath(filename, backing_filename)) { - error_setg_errno(errp, errno, "Could not resolve path '%s'", filename); ret = -errno; + error_setg_errno(errp, errno, "Could not resolve path '%s'", filename); goto fail; } -- 1.8.3.1