From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeQcO-0006qI-EI for qemu-devel@nongnu.org; Thu, 07 Nov 2013 09:31:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeQcF-0006p4-Fn for qemu-devel@nongnu.org; Thu, 07 Nov 2013 09:31:32 -0500 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:54040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeQcE-0006oW-SP for qemu-devel@nongnu.org; Thu, 07 Nov 2013 09:31:23 -0500 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Nov 2013 20:01:18 +0530 From: "Aneesh Kumar K.V" Date: Thu, 7 Nov 2013 20:01:01 +0530 Message-Id: <1383834662-12473-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1383834662-12473-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1383834662-12473-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH -V7 2/3] target-ppc: Fix htab_mask calculation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: agraf@suse.de, paulus@samba.org Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, "Aneesh Kumar K.V" From: "Aneesh Kumar K.V" Correctly update the htab_mask using the return value of KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1 on GET_SREGS for HV. So don't update htab_mask if sdr1 is found to be zero. Fix the pte index calculation to be same as that found in the kernel Signed-off-by: Aneesh Kumar K.V --- hw/ppc/spapr.c | 3 ++- target-ppc/mmu_helper.c | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 22f2a8a..d4f3502 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -724,7 +724,8 @@ static void spapr_cpu_reset(void *opaque) env->external_htab = (void *)1; } env->htab_base = -1; - env->htab_mask = HTAB_SIZE(spapr) - 1; + /* 128 (2**7) bytes in each HPTEG */ + env->htab_mask = (1ULL << ((spapr)->htab_shift - 7)) - 1; env->spr[SPR_SDR1] = (target_ulong)(uintptr_t)spapr->htab | (spapr->htab_shift - 18); } diff --git a/target-ppc/mmu_helper.c b/target-ppc/mmu_helper.c index 04a840b..c39cb7b 100644 --- a/target-ppc/mmu_helper.c +++ b/target-ppc/mmu_helper.c @@ -2025,7 +2025,9 @@ void ppc_store_sdr1(CPUPPCState *env, target_ulong value) " stored in SDR1\n", htabsize); htabsize = 28; } - env->htab_mask = (1ULL << (htabsize + 18)) - 1; + if (htabsize) { + env->htab_mask = (1ULL << (htabsize + 18 - 7)) - 1; + } env->htab_base = value & SDR_64_HTABORG; } else #endif /* defined(TARGET_PPC64) */ -- 1.8.3.2