From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VfTyE-000555-U6 for qemu-devel@nongnu.org; Sun, 10 Nov 2013 07:18:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VfTy8-0003DM-VD for qemu-devel@nongnu.org; Sun, 10 Nov 2013 07:18:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VfTy8-0003D5-Mt for qemu-devel@nongnu.org; Sun, 10 Nov 2013 07:18:20 -0500 From: Marcel Apfelbaum Date: Sun, 10 Nov 2013 14:15:23 +0200 Message-Id: <1384085725-23522-1-git-send-email-marcel.a@redhat.com> Subject: [Qemu-devel] [PATCH for-1.7 0/2] revert master abort related patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, agraf@suse.de, lcapitulino@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, lersek@redhat.com, afaerber@suse.de, rth@twiddle.net The master-abort patch introduced a background memory region covering all 64 bit pci address space, the visible parts being the unused pci-holes addresses. The patch revealed the following issues: 1. Some memory regions have INT64_MAX size, but the size was supposed to be UINT64_MAX (meaning that the region covers all 64 bit address space). Having a region that is not even a multiple of PAGE_SIZE is really not what we want. 2. exec.c does not support all the 64 bit address range and when using an unsupported address, it leads to page tables corruption. 3. Some memory regions overlap and the visible region is selected by chance (the algorithm implementation) and not by the memory API: - selecting a proper priority - arrange the regions that are not supposed to overlap. This series reverts this patch and another related patch because the impact for 1.7 is too big. After the issues above are solved, the patch can finally be applied. Marcel Apfelbaum (1): Revert "hw/pci: partially handle pci master abort" Michael S. Tsirkin (1): Revert "exec: limit system memory size" exec.c | 7 +------ hw/pci/pci.c | 26 -------------------------- include/hw/pci/pci_bus.h | 1 - 3 files changed, 1 insertion(+), 33 deletions(-) -- 1.8.3.1