From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgOi7-0001En-DM for qemu-devel@nongnu.org; Tue, 12 Nov 2013 19:53:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgOi1-0005wF-AW for qemu-devel@nongnu.org; Tue, 12 Nov 2013 19:53:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgOi1-0005vu-2r for qemu-devel@nongnu.org; Tue, 12 Nov 2013 19:53:29 -0500 From: Fam Zheng Date: Wed, 13 Nov 2013 08:53:14 +0800 Message-Id: <1384303994-26796-6-git-send-email-famz@redhat.com> In-Reply-To: <1384303994-26796-1-git-send-email-famz@redhat.com> References: <1384303994-26796-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH 5/5] mirror: Check for bdrv_get_info result List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, gentoo.integer@gmail.com, stefanha@redhat.com bdrv_get_info could fail. Add check before using the returned value. Signed-off-by: Fam Zheng --- block/mirror.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 7b95acf..c0c321b 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -320,8 +320,8 @@ static void coroutine_fn mirror_run(void *opaque) bdrv_get_backing_filename(s->target, backing_filename, sizeof(backing_filename)); if (backing_filename[0] && !s->target->backing_hd) { - bdrv_get_info(s->target, &bdi); - if (s->granularity < bdi.cluster_size) { + ret = bdrv_get_info(s->target, &bdi); + if (ret == 0 && s->granularity < bdi.cluster_size) { s->buf_size = MAX(s->buf_size, bdi.cluster_size); s->cow_bitmap = bitmap_new(length); } -- 1.8.4.2