* [Qemu-devel] [PATCH] qemu-iotests: Use cache=writeback in drive_add
@ 2013-11-13 12:27 Fam Zheng
2013-11-13 13:39 ` Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Fam Zheng @ 2013-11-13 12:27 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, stefanha
This will allow running iotests on tmpfs, which is much faster, so we
can run more tests.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/qemu-iotests/iotests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index fb10ff4..c29314a 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -96,7 +96,7 @@ class VM(object):
'''Add a virtio-blk drive to the VM'''
options = ['if=virtio',
'format=%s' % imgfmt,
- 'cache=none',
+ 'cache=writeback',
'file=%s' % path,
'id=drive%d' % self._num_drives]
if opts:
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-iotests: Use cache=writeback in drive_add
2013-11-13 12:27 [Qemu-devel] [PATCH] qemu-iotests: Use cache=writeback in drive_add Fam Zheng
@ 2013-11-13 13:39 ` Kevin Wolf
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Wolf @ 2013-11-13 13:39 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, stefanha
Am 13.11.2013 um 13:27 hat Fam Zheng geschrieben:
> This will allow running iotests on tmpfs, which is much faster, so we
> can run more tests.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/qemu-iotests/iotests.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index fb10ff4..c29314a 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -96,7 +96,7 @@ class VM(object):
> '''Add a virtio-blk drive to the VM'''
> options = ['if=virtio',
> 'format=%s' % imgfmt,
> - 'cache=none',
> + 'cache=writeback',
> 'file=%s' % path,
> 'id=drive%d' % self._num_drives]
> if opts:
Well, in fact any fixed value is wrong here. By default, qemu-iotests is
supposed to use cache=writethrough for everything, and ./check -nocache
should make it cache=none. I think what we really want is a ./check
option that allows specifying any cache option, and then we should make
the scripts honour that option.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-13 13:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-13 12:27 [Qemu-devel] [PATCH] qemu-iotests: Use cache=writeback in drive_add Fam Zheng
2013-11-13 13:39 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).