From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45993)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1VgxH6-0004hS-KH
	for qemu-devel@nongnu.org; Thu, 14 Nov 2013 08:48:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1VgxGy-0003t0-5r
	for qemu-devel@nongnu.org; Thu, 14 Nov 2013 08:48:00 -0500
Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]:44144)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1VgxGx-0003sw-VE
	for qemu-devel@nongnu.org; Thu, 14 Nov 2013 08:47:52 -0500
Received: by mail-wg0-f46.google.com with SMTP id x12so1945457wgg.25
	for <qemu-devel@nongnu.org>; Thu, 14 Nov 2013 05:47:50 -0800 (PST)
Message-ID: <1384436700.27694.19.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Date: Thu, 14 Nov 2013 15:45:00 +0200
In-Reply-To: <20131114120116.GA4149@redhat.com>
References: <20131114120116.GA4149@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] acpi: strip compiler info in built-in DSDT
Reply-To: marcel.a@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Dave Frodin <dave.frodin@se-eng.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>, Magnus Christensson <magnus.christensson@intel.com>

On Thu, 2013-11-14 at 14:01 +0200, Michael S. Tsirkin wrote:
> IASL stores it's revision in each table header it generates.
> That's not nice since guests will see a change each time
> they move between hypervisors.
> We generally fill our own info for tables,
> but we (and seabios) forgot to do this for the built-in DSDT.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Modifications in DSDT table:
 OEM ID:            "BXPC" -> "BOCHS "
 OEM Table ID:      "BXDSDT" -> "BXPCDSDT"
 Compiler ID:       "INTL" -> "BXPC"
 Compiler Version:  0x20130823 -> 0x00000001

Tested-by: Marcel Apfelbaum <marcel.a@redhat.com>


> ---
> 
> Probably not important enough for 1.7. Queued for 1.8.
> 
>  hw/i386/acpi-build.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 486e705..8ae4f26 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -921,10 +921,16 @@ build_mcfg_q35(GArray *table_data, GArray *linker, AcpiMcfgInfo *info)
>  static void
>  build_dsdt(GArray *table_data, GArray *linker, AcpiMiscInfo *misc)
>  {
> -    void *dsdt;
> +    AcpiTableHeader *dsdt;
> +
>      assert(misc->dsdt_code && misc->dsdt_size);
> +
>      dsdt = acpi_data_push(table_data, misc->dsdt_size);
>      memcpy(dsdt, misc->dsdt_code, misc->dsdt_size);
> +
> +    memset(dsdt, 0, sizeof *dsdt);
> +    build_header(linker, table_data, dsdt, ACPI_DSDT_SIGNATURE,
> +                 misc->dsdt_size, 1);
>  }
>  
>  /* Build final rsdt table */