qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vlad Yasevich <vyasevic@redhat.com>
To: qemu-devel@nongnu.org
Cc: Vlad Yasevich <vyasevic@redhat.com>
Subject: [Qemu-devel] [PATCH] qom: Fix memory leak in object_property_set_link()
Date: Fri, 15 Nov 2013 12:06:56 -0500	[thread overview]
Message-ID: <1384535216-6171-1-git-send-email-vyasevic@redhat.com> (raw)

Save the result of the call to object_get_cannonical_path()
so we can free it.

Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
---
 qom/object.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/qom/object.c b/qom/object.c
index b617f26..21b6f87 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -838,8 +838,9 @@ char *object_property_get_str(Object *obj, const char *name,
 void object_property_set_link(Object *obj, Object *value,
                               const char *name, Error **errp)
 {
-    object_property_set_str(obj, object_get_canonical_path(value),
-                            name, errp);
+    gchar *path = object_get_cannonical_path(value);
+    object_property_set_str(obj, path, name, errp);
+    gfree(path);
 }
 
 Object *object_property_get_link(Object *obj, const char *name,
-- 
1.8.4.2

             reply	other threads:[~2013-11-15 17:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15 17:06 Vlad Yasevich [this message]
2013-11-15 17:08 ` [Qemu-devel] [PATCH] qom: Fix memory leak in object_property_set_link() Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384535216-6171-1-git-send-email-vyasevic@redhat.com \
    --to=vyasevic@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).