* [Qemu-devel] [PATCH] qom: Fix memory leak in object_property_set_link()
@ 2013-11-15 17:06 Vlad Yasevich
2013-11-15 17:08 ` Vlad Yasevich
0 siblings, 1 reply; 2+ messages in thread
From: Vlad Yasevich @ 2013-11-15 17:06 UTC (permalink / raw)
To: qemu-devel; +Cc: Vlad Yasevich
Save the result of the call to object_get_cannonical_path()
so we can free it.
Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
---
qom/object.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index b617f26..21b6f87 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -838,8 +838,9 @@ char *object_property_get_str(Object *obj, const char *name,
void object_property_set_link(Object *obj, Object *value,
const char *name, Error **errp)
{
- object_property_set_str(obj, object_get_canonical_path(value),
- name, errp);
+ gchar *path = object_get_cannonical_path(value);
+ object_property_set_str(obj, path, name, errp);
+ gfree(path);
}
Object *object_property_get_link(Object *obj, const char *name,
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qom: Fix memory leak in object_property_set_link()
2013-11-15 17:06 [Qemu-devel] [PATCH] qom: Fix memory leak in object_property_set_link() Vlad Yasevich
@ 2013-11-15 17:08 ` Vlad Yasevich
0 siblings, 0 replies; 2+ messages in thread
From: Vlad Yasevich @ 2013-11-15 17:08 UTC (permalink / raw)
To: qemu-devel
On 11/15/2013 12:06 PM, Vlad Yasevich wrote:
> Save the result of the call to object_get_cannonical_path()
> so we can free it.
>
> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
> ---
> qom/object.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index b617f26..21b6f87 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -838,8 +838,9 @@ char *object_property_get_str(Object *obj, const char *name,
> void object_property_set_link(Object *obj, Object *value,
> const char *name, Error **errp)
> {
> - object_property_set_str(obj, object_get_canonical_path(value),
> - name, errp);
> + gchar *path = object_get_cannonical_path(value);
> + object_property_set_str(obj, path, name, errp);
> + gfree(path);
> }
>
> Object *object_property_get_link(Object *obj, const char *name,
>
Self-nack. Forgot to commit the changes that actually make it build and
work :/
-vlad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-15 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-15 17:06 [Qemu-devel] [PATCH] qom: Fix memory leak in object_property_set_link() Vlad Yasevich
2013-11-15 17:08 ` Vlad Yasevich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).