From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vi6eQ-0005sE-CI for qemu-devel@nongnu.org; Sun, 17 Nov 2013 13:00:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vi6eL-0001yn-PH for qemu-devel@nongnu.org; Sun, 17 Nov 2013 13:00:50 -0500 From: Stefan Weil Date: Sun, 17 Nov 2013 19:00:42 +0100 Message-Id: <1384711242-8978-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH for 1.7] qobject: Fix compiler warning (missing gnu_printf format attribute) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-trivial@nongnu.org, Stefan Weil , qemu-devel gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra): CC qobject/qerror.o qobject/qerror.c: In function =E2=80=98qerror_from_info=E2=80=99: qobject/qerror.c:53:5: error: function might be possible candidate for =E2=80=98gnu_printf=E2=80=99 fo= rmat attribute [-Werror=3Dsuggest-attribute=3Dformat] qerr->err_msg =3D g_strdup_vprintf(fmt, *va); ^ Signed-off-by: Stefan Weil --- Note: checkpatch.pl wrongly reports an error. qobject/qerror.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qobject/qerror.c b/qobject/qerror.c index 3aee1cf..fc8331a 100644 --- a/qobject/qerror.c +++ b/qobject/qerror.c @@ -42,8 +42,8 @@ static QError *qerror_new(void) * * Return strong reference. */ -static QError *qerror_from_info(ErrorClass err_class, const char *fmt, - va_list *va) +static QError * GCC_FMT_ATTR(2, 0) +qerror_from_info(ErrorClass err_class, const char *fmt, va_list *va) { QError *qerr; =20 --=20 1.7.10.4