From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vi6el-0006OQ-DR for qemu-devel@nongnu.org; Sun, 17 Nov 2013 13:01:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vi6ek-00021w-Iv for qemu-devel@nongnu.org; Sun, 17 Nov 2013 13:01:11 -0500 From: Stefan Weil Date: Sun, 17 Nov 2013 19:01:07 +0100 Message-Id: <1384711267-9032-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH for 1.7] qga: Fix compiler warnings (missing gnu_printf format attribute, wrong format string) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-trivial@nongnu.org, Stefan Weil , qemu-devel gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra): CC qga/commands.o qga/commands.c: In function =E2=80=98slog=E2=80=99: qga/commands.c:28:5: error: function might be possible candidate for =E2=80=98gnu_printf=E2=80=99 fo= rmat attribute [-Werror=3Dsuggest-attribute=3Dformat] g_logv("syslog", G_LOG_LEVEL_INFO, fmt, ap); ^ gcc 4.8.2 reports this warning when slog is declared with the gnu_printf format attribute: qga/commands-posix.c: In function =E2=80=98qmp_guest_file_open=E2=80=99: qga/commands-posix.c:404:5: warning: format =E2=80=98%d=E2=80=99 expects argument of type =E2=80=98int=E2=80=99= , but argument 2 has type =E2=80=98int64_t=E2=80=99 [-Wformat=3D] slog("guest-file-open, handle: %d", handle); ^ Signed-off-by: Stefan Weil --- Note: checkpatch.pl wrongly reports an error. qga/commands-posix.c | 2 +- qga/guest-agent-core.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index f453132..182279d 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -401,7 +401,7 @@ int64_t qmp_guest_file_open(const char *path, bool ha= s_mode, const char *mode, E return -1; } =20 - slog("guest-file-open, handle: %d", handle); + slog("guest-file-open, handle: %" PRId64, handle); return handle; } =20 diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h index 624a559..95721eb 100644 --- a/qga/guest-agent-core.h +++ b/qga/guest-agent-core.h @@ -29,7 +29,7 @@ GACommandState *ga_command_state_new(void); bool ga_logging_enabled(GAState *s); void ga_disable_logging(GAState *s); void ga_enable_logging(GAState *s); -void slog(const gchar *fmt, ...); +void GCC_FMT_ATTR(1, 2) slog(const gchar *fmt, ...); void ga_set_response_delimited(GAState *s); bool ga_is_frozen(GAState *s); void ga_set_frozen(GAState *s); --=20 1.7.10.4