[Qemu-devel] [PATCH] target-ppc: remove MMUCFG SPR from POWER7/8 class

[Qemu-devel] [PATCH] target-ppc: remove MMUCFG SPR from POWER7/8 class

[Alexey Kardashevskiy]

PowerISA 2.06/2.07 put MMUCFG SPR to "E" (embedded) category so
remove it from POWER7/8 class as it is "S" (server) category.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 target-ppc/translate_init.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index c90d1c6..96a7b2f 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -7194,12 +7194,6 @@ static void init_proc_POWER7 (CPUPPCState *env)
                      &spr_read_generic, &spr_write_generic,
                      KVM_REG_PPC_PMC6, 0x00000000);
 #endif /* !CONFIG_USER_ONLY */
-    /* Memory management */
-    /* XXX : not implemented */
-    spr_register(env, SPR_MMUCFG, "MMUCFG",
-                 SPR_NOACCESS, SPR_NOACCESS,
-                 &spr_read_generic, SPR_NOACCESS,
-                 0x00000000); /* TOFIX */
     gen_spr_amr(env);
     /* XXX : not implemented */
     spr_register(env, SPR_CTRL, "SPR_CTRLT",
-- 
1.8.4.rc4

Re: [Qemu-devel] [PATCH] target-ppc: remove MMUCFG SPR from POWER7/8 class

[Alexander Graf]

On 18.11.2013, at 09:29, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:

> PowerISA 2.06/2.07 put MMUCFG SPR to "E" (embedded) category so
> remove it from POWER7/8 class as it is "S" (server) category.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

POWER7 inherited this from the other 64bit cores. Does any of those actually implement MMUCFG? It's definitely category E in the 2.04 ISA already.

Please check all supported CPU types' book iv's and remove MMUCFG (and maybe other SPRs if you can spot them) if it's not really implemented on hardware.


Alex